From: Mikulas Patocka <mpatocka@redhat.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: dm-devel@redhat.com, linux-crypto@vger.kernel.org,
Alasdair G Kergon <agk@redhat.com>
Subject: Re: Desynchronizing dm-raid1
Date: Thu, 22 May 2008 08:32:45 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0805220828500.15805@engineering.redhat.com> (raw)
In-Reply-To: <20080522024225.GA28400@gondor.apana.org.au>
>> All the ciphers comply, so the bug is only a theroretical issue (but I
>> didn't check assembler versions --- they should be checked by the person
>> who wrote them, assembler is write-only language).
>
> Since every current algorithm sets the flag could you invert
> its sense? Sorry to have to do this to you :)
>
> Thanks,
There may be external modules.
If you don't set the flag when it should be set, nothing happens (just a
slight performance drop), if you set the flag when it shouldn't be set,
you get data corruption. So the safest way is this meaning of flag, so
that not-yet-reviewed algorithms set the flag to 0 and prevent data
corruption.
Mikulas
next prev parent reply other threads:[~2008-05-22 12:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <47DEC402.10309@redhat.com>
[not found] ` <Pine.LNX.4.64.0803171611430.31803@porkchop.devel.redhat.com>
[not found] ` <20080317215631.GG29322@agk.fab.redhat.com>
[not found] ` <Pine.LNX.4.64.0803181921380.10939@porkchop.devel.redhat.com>
[not found] ` <20080318233955.GA12007@agk.fab.redhat.com>
[not found] ` <Pine.LNX.4.64.0803181942140.20490@porkchop.devel.redhat.com>
[not found] ` <20080319000241.GB12007@agk.fab.redhat.com>
[not found] ` <Pine.LNX.4.64.0803182015001.21077@porkchop.devel.redhat.com>
[not found] ` <20080319011757.GD12007@agk.fab.redhat.com>
[not found] ` <Pine.LNX.4.64.0804021444120.22485@porkchop.devel.redhat.com>
[not found] ` <20080403014042.GA3789@us.ibm.com>
[not found] ` <yq14padoast.fsf@sermon.lab.mkp.net>
2008-05-05 21:45 ` Desynchronizing dm-raid1 Mikulas Patocka
2008-05-06 10:29 ` [dm-devel] " Herbert Xu
2008-05-06 22:50 ` Mikulas Patocka
2008-05-13 3:28 ` Mikulas Patocka
2008-05-13 3:38 ` [dm-devel] " Herbert Xu
2008-05-13 20:35 ` Mikulas Patocka
2008-05-14 1:14 ` [dm-devel] " Herbert Xu
2008-05-22 2:18 ` Mikulas Patocka
2008-05-22 2:42 ` [dm-devel] " Herbert Xu
2008-05-22 12:32 ` Mikulas Patocka [this message]
2008-05-22 23:53 ` Herbert Xu
2008-05-23 14:59 ` Mikulas Patocka
2008-05-24 0:01 ` Herbert Xu
2008-05-24 14:01 ` Mikulas Patocka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0805220828500.15805@engineering.redhat.com \
--to=mpatocka@redhat.com \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox