From: Eric Biggers <ebiggers@kernel.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Linux Crypto Mailing List <linux-crypto@vger.kernel.org>
Subject: Re: [PATCH 8/10] crypto: rng - Count error stats differently
Date: Wed, 15 Feb 2023 22:01:12 -0800 [thread overview]
Message-ID: <Y+3GqFH/DQw3mfYn@sol.localdomain> (raw)
In-Reply-To: <Y+3FlS3c/MOEogt+@gondor.apana.org.au>
On Thu, Feb 16, 2023 at 01:56:37PM +0800, Herbert Xu wrote:
> On Wed, Feb 15, 2023 at 09:46:34PM -0800, Eric Biggers wrote:
> >
> > Please keep field comments in the same order as the fields themselves.
>
> Is that a requirement of kdoc? Because we may need to rearrange
> the fields from time to time in order to minimise unnecessary
> padding and moving comments around at the same time woulds seem
> to create unnecessary churn.
>
scripts/kernel-doc doesn't complain. It makes it harder to find the
documentation if it's in some random order, though.
- Eric
next prev parent reply other threads:[~2023-02-16 6:01 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 9:24 [PATCH 0/10] crypto: api - Restructure stats code Herbert Xu
2023-02-15 9:25 ` [PATCH 1/10] crypto: algapi - Move stat reporting into algapi Herbert Xu
2023-02-15 9:25 ` [PATCH 2/10] crypto: aead - Count error stats differently Herbert Xu
2023-02-16 5:35 ` Eric Biggers
2023-02-16 5:58 ` Herbert Xu
2023-02-16 5:45 ` Eric Biggers
2023-02-16 6:00 ` Herbert Xu
2023-02-16 6:31 ` Eric Biggers
2023-02-16 8:34 ` Herbert Xu
2023-02-15 9:25 ` [PATCH 3/10] crypto: akcipher " Herbert Xu
2023-02-15 9:25 ` [PATCH 4/10] crypto: hash " Herbert Xu
2023-02-16 5:58 ` Eric Biggers
2023-02-16 6:02 ` Herbert Xu
2023-02-16 6:14 ` Eric Biggers
2023-02-16 8:09 ` Herbert Xu
2023-02-15 9:25 ` [PATCH 5/10] crypto: acomp " Herbert Xu
2023-02-15 9:25 ` [PATCH 6/10] crypto: kpp " Herbert Xu
2023-02-15 9:25 ` [PATCH 7/10] crypto: skcipher " Herbert Xu
2023-02-15 9:25 ` [PATCH 8/10] crypto: rng " Herbert Xu
2023-02-16 5:46 ` Eric Biggers
2023-02-16 5:56 ` Herbert Xu
2023-02-16 6:01 ` Eric Biggers [this message]
2023-02-15 9:25 ` [PATCH 9/10] crypto: api - Move MODULE_ALIAS_CRYPTO to algapi.h Herbert Xu
2023-02-16 5:17 ` Eric Biggers
2023-02-16 5:18 ` Herbert Xu
2023-02-15 9:25 ` [PATCH 10/10] crypto: api - Check CRYPTO_USER instead of NET for report Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+3GqFH/DQw3mfYn@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox