From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: linux-crypto@vger.kernel.org, herbert@gondor.apana.org.au,
ebiggers@kernel.org, keescook@chromium.org,
"Nikunj A. Dadhania" <nikunj@amd.com>
Subject: Re: [PATCH] crypto: gcm - Provide minimal library implementation
Date: Fri, 7 Oct 2022 17:30:52 +0200 [thread overview]
Message-ID: <Y0BGLKzJ1tzuYgxf@zx2c4.com> (raw)
In-Reply-To: <20221007152105.3057788-1-ardb@kernel.org>
I haven't looked at this in depth yet, but one thing jumped out:
On Fri, Oct 07, 2022 at 05:21:05PM +0200, Ard Biesheuvel wrote:
> Implement a minimal library version of GCM based on the existing library
> include/crypto/gcm.h | 61 ++
> lib/crypto/gcm.c | 714 ++++++++++++++++++++
> +void gcm_encrypt(const struct gcm_ctx *ctx, u8 *dst, const u8 *src,
> + int crypt_len, const u8 *assoc, int assoc_len,
> + const u8 iv[GCM_AES_IV_SIZE], u8 *authtag);
This should probably all be aes_gcm, aes-gcm.[ch] LIB_AES_GCM and so
forth, since GCM is something that works with different block ciphers.
Jason
next prev parent reply other threads:[~2022-10-07 15:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-07 15:21 [PATCH] crypto: gcm - Provide minimal library implementation Ard Biesheuvel
2022-10-07 15:30 ` Jason A. Donenfeld [this message]
2022-10-10 7:27 ` Nikunj A. Dadhania
2022-10-10 8:15 ` Ard Biesheuvel
2022-10-10 8:25 ` Nikunj A. Dadhania
2022-10-10 8:44 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0BGLKzJ1tzuYgxf@zx2c4.com \
--to=jason@zx2c4.com \
--cc=ardb@kernel.org \
--cc=ebiggers@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=keescook@chromium.org \
--cc=linux-crypto@vger.kernel.org \
--cc=nikunj@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox