From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7844BC433FE for ; Fri, 11 Nov 2022 18:15:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234085AbiKKSO7 (ORCPT ); Fri, 11 Nov 2022 13:14:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56492 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232949AbiKKSO6 (ORCPT ); Fri, 11 Nov 2022 13:14:58 -0500 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 57555682AB; Fri, 11 Nov 2022 10:14:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668190496; x=1699726496; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=rLc5Ixga1hS37ddV0n0/E/iWK+ZYtrwFO7ML+W9DUPo=; b=d1zxWujy/UzRUkKilJL4qgSxC4wQj7E3ZAmJoRqf/pWhi3L0CgvZhy0V bYgcjzlj1mCFvE2OZQrDVqrxTT8NCl3w+XdrXf/QMquEPUcWDD5aT3cTY gVfkWhefLmAh8UvM77DWWrAhMcKdx5c+yKFopqCct1UXefEA2X5uVcJV7 hGG0jadyH9kXllyPRH1UyTY5F0j0iRLVHgxRkO08Fnaz1rRPzIHLX320x bbL8jRDjGGE5sa5PZGGur9Tr5HUr3MXFkeHqN78NJTHp2GY7bjGQiBbW5 O1IZGcCkSr5Ih7zB7gCRwHl86fVZsckUmTqedcmUnD8XcJgiOlz2rtCng w==; X-IronPort-AV: E=McAfee;i="6500,9779,10528"; a="312792388" X-IronPort-AV: E=Sophos;i="5.96,157,1665471600"; d="scan'208";a="312792388" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Nov 2022 10:14:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10528"; a="812512249" X-IronPort-AV: E=Sophos;i="5.96,157,1665471600"; d="scan'208";a="812512249" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga005.jf.intel.com with ESMTP; 11 Nov 2022 10:14:48 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1otYY8-00Aq5e-35; Fri, 11 Nov 2022 20:14:44 +0200 Date: Fri, 11 Nov 2022 20:14:44 +0200 From: Andy Shevchenko To: Yury Norov Cc: linux-kernel@vger.kernel.org, "David S. Miller" , Barry Song , Ben Segall , Daniel Bristot de Oliveira , Dietmar Eggemann , Gal Pressman , Greg Kroah-Hartman , Heiko Carstens , Ingo Molnar , Jakub Kicinski , Jason Gunthorpe , Jesse Brandeburg , Jonathan Cameron , Juri Lelli , Leon Romanovsky , Mel Gorman , Peter Zijlstra , Rasmus Villemoes , Saeed Mahameed , Steven Rostedt , Tariq Toukan , Tariq Toukan , Tony Luck , Valentin Schneider , Vincent Guittot , linux-crypto@vger.kernel.org, netdev@vger.kernel.org, linux-rdma@vger.kernel.org Subject: Re: [PATCH 3/4] sched: add sched_numa_find_nth_cpu() Message-ID: References: <20221111040027.621646-1-yury.norov@gmail.com> <20221111040027.621646-4-yury.norov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Fri, Nov 11, 2022 at 09:07:15AM -0800, Yury Norov wrote: > On Fri, Nov 11, 2022 at 01:42:29PM +0200, Andy Shevchenko wrote: > > On Thu, Nov 10, 2022 at 08:00:26PM -0800, Yury Norov wrote: ... > > > +out: > > > > out_unlock: ? > > Do you think it's better? Yes. It shows what will happen at goto. So when one reads the "goto out;" it's something like "return ret;". But "goto out_unlock;" immediately pictures "unlock; return ret;". P.S. That's basically the way how we name labels. > > > + rcu_read_unlock(); > > > + return ret; -- With Best Regards, Andy Shevchenko