From: Eric Biggers <ebiggers@kernel.org>
To: Alexey Khoroshilov <khoroshilov@ispras.ru>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
lvc-project@linuxtesting.org
Subject: Re: [PATCH] crypto: algapi - fix be32_to_cpu macro call in crypto_inc()
Date: Wed, 16 Nov 2022 09:39:31 -0800 [thread overview]
Message-ID: <Y3UgUwwV4qZMrzar@sol.localdomain> (raw)
In-Reply-To: <1668606771-5382-1-git-send-email-khoroshilov@ispras.ru>
On Wed, Nov 16, 2022 at 04:52:51PM +0300, Alexey Khoroshilov wrote:
> be32_to_cpu() macro in some cases may be expanded to an expression
> that evaluates its arguments multiple times.
When is that, exactly?
If that's true, then lots of other places in the kernel would need to be fixed
too. Try running:
git grep -E '[bl]e(16|32|64)_to_cpu\([^)]+\+\+\)'
If true, then it would be much better to fix the macros.
But more likely is that there isn't actually any problem.
- Eric
next prev parent reply other threads:[~2022-11-16 17:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-16 13:52 [PATCH] crypto: algapi - fix be32_to_cpu macro call in crypto_inc() Alexey Khoroshilov
2022-11-16 17:39 ` Eric Biggers [this message]
2022-11-16 23:15 ` Alexey Khoroshilov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3UgUwwV4qZMrzar@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=khoroshilov@ispras.ru \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox