From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: linux-kernel@vger.kernel.org, patches@lists.linux.dev,
tglx@linutronix.de, linux-crypto@vger.kernel.org,
linux-api@vger.kernel.org, x86@kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>,
Carlos O'Donell <carlos@redhat.com>,
Arnd Bergmann <arnd@arndb.de>,
Christian Brauner <brauner@kernel.org>
Subject: Re: [PATCH v11 1/4] random: add vgetrandom_alloc() syscall
Date: Mon, 5 Dec 2022 19:38:16 +0100 [thread overview]
Message-ID: <Y446mGVCvJX+5mGd@zx2c4.com> (raw)
In-Reply-To: <87cz8xr96o.fsf@oldenburg.str.redhat.com>
On Mon, Dec 05, 2022 at 07:34:39PM +0100, Florian Weimer wrote:
> > + * - Passing the first state to munmap(2), as described above.
> > + * All other uses are undefined behavior, which is subject to change or removal
>
> Suggest: “Passing the first state *and total length* to munmap(2)”
Will do.
> Rest of the documentation looks good to me. It addresses my concerns
> about future evolution of this interface.
Great! So hopefully the api is more or less settled now, and we can turn
attention to the glibc part.
Jason
next prev parent reply other threads:[~2022-12-05 18:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-05 2:00 [PATCH v11 0/4] implement getrandom() in vDSO Jason A. Donenfeld
2022-12-05 2:00 ` [PATCH v11 1/4] random: add vgetrandom_alloc() syscall Jason A. Donenfeld
2022-12-05 18:34 ` Florian Weimer
2022-12-05 18:38 ` Jason A. Donenfeld [this message]
2022-12-05 19:13 ` Jann Horn
2022-12-05 20:02 ` Jason A. Donenfeld
2022-12-05 20:06 ` Florian Weimer
2022-12-06 12:57 ` Jason A. Donenfeld
2022-12-05 2:00 ` [PATCH v11 2/4] arch: allocate vgetrandom_alloc() syscall number Jason A. Donenfeld
2022-12-05 2:00 ` [PATCH v11 3/4] random: introduce generic vDSO getrandom() implementation Jason A. Donenfeld
2022-12-05 18:56 ` Florian Weimer
2022-12-05 19:04 ` Jason A. Donenfeld
2022-12-05 19:35 ` Florian Weimer
2022-12-05 2:00 ` [PATCH v11 4/4] x86: vdso: Wire up getrandom() vDSO implementation Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y446mGVCvJX+5mGd@zx2c4.com \
--to=jason@zx2c4.com \
--cc=adhemerval.zanella@linaro.org \
--cc=arnd@arndb.de \
--cc=brauner@kernel.org \
--cc=carlos@redhat.com \
--cc=fweimer@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@lists.linux.dev \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).