Linux cryptographic layer development
 help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Eric Biggers <ebiggers@kernel.org>
Cc: linux-crypto@vger.kernel.org, x86@kernel.org,
	linux-arm-kernel@lists.infradead.org, samitolvanen@google.com
Subject: Re: [PATCH v2 00/12] crypto: CFI fixes
Date: Fri, 25 Nov 2022 17:46:00 +0800	[thread overview]
Message-ID: <Y4CO2C6QatznTz5i@gondor.apana.org.au> (raw)
In-Reply-To: <20221118194421.160414-1-ebiggers@kernel.org>

Eric Biggers <ebiggers@kernel.org> wrote:
> This series fixes some crashes when CONFIG_CFI_CLANG (Control Flow
> Integrity) is enabled, with the new CFI implementation that was merged
> in 6.1 and is supported on x86.  Some of them were unconditional
> crashes, while others depended on whether the compiler optimized out the
> indirect calls or not.  This series also simplifies some code that was
> intended to work around limitations of the old CFI implementation and is
> unnecessary for the new CFI implementation.
> 
> Changed in v2:
>  - Added patch "crypto: x86/sm4 - fix crash with CFI enabled"
>  - Restored accidentally-deleted include of <asm/assembler.h>
>  - Tweaked some commit messages and added Reviewed-by and Acked-by tags
> 
> Eric Biggers (12):
>  crypto: x86/aegis128 - fix possible crash with CFI enabled
>  crypto: x86/aria - fix crash with CFI enabled
>  crypto: x86/nhpoly1305 - eliminate unnecessary CFI wrappers
>  crypto: x86/sha1 - fix possible crash with CFI enabled
>  crypto: x86/sha256 - fix possible crash with CFI enabled
>  crypto: x86/sha512 - fix possible crash with CFI enabled
>  crypto: x86/sm3 - fix possible crash with CFI enabled
>  crypto: x86/sm4 - fix crash with CFI enabled
>  crypto: arm64/nhpoly1305 - eliminate unnecessary CFI wrapper
>  crypto: arm64/sm3 - fix possible crash with CFI enabled
>  crypto: arm/nhpoly1305 - eliminate unnecessary CFI wrapper
>  Revert "crypto: shash - avoid comparing pointers to exported functions
>    under CFI"
> 
> arch/arm/crypto/nh-neon-core.S           |  2 +-
> arch/arm/crypto/nhpoly1305-neon-glue.c   | 11 ++---------
> arch/arm64/crypto/nh-neon-core.S         |  5 +++--
> arch/arm64/crypto/nhpoly1305-neon-glue.c | 11 ++---------
> arch/arm64/crypto/sm3-neon-core.S        |  3 ++-
> arch/x86/crypto/aegis128-aesni-asm.S     |  9 +++++----
> arch/x86/crypto/aria-aesni-avx-asm_64.S  | 13 +++++++------
> arch/x86/crypto/nh-avx2-x86_64.S         |  5 +++--
> arch/x86/crypto/nh-sse2-x86_64.S         |  5 +++--
> arch/x86/crypto/nhpoly1305-avx2-glue.c   | 11 ++---------
> arch/x86/crypto/nhpoly1305-sse2-glue.c   | 11 ++---------
> arch/x86/crypto/sha1_ni_asm.S            |  3 ++-
> arch/x86/crypto/sha1_ssse3_asm.S         |  3 ++-
> arch/x86/crypto/sha256-avx-asm.S         |  3 ++-
> arch/x86/crypto/sha256-avx2-asm.S        |  3 ++-
> arch/x86/crypto/sha256-ssse3-asm.S       |  3 ++-
> arch/x86/crypto/sha256_ni_asm.S          |  3 ++-
> arch/x86/crypto/sha512-avx-asm.S         |  3 ++-
> arch/x86/crypto/sha512-avx2-asm.S        |  3 ++-
> arch/x86/crypto/sha512-ssse3-asm.S       |  3 ++-
> arch/x86/crypto/sm3-avx-asm_64.S         |  3 ++-
> arch/x86/crypto/sm4-aesni-avx-asm_64.S   |  7 ++++---
> arch/x86/crypto/sm4-aesni-avx2-asm_64.S  |  7 ++++---
> crypto/shash.c                           | 18 +++---------------
> include/crypto/internal/hash.h           |  8 +++++++-
> 25 files changed, 70 insertions(+), 86 deletions(-)
> 
> 
> base-commit: 75df46b598b5b46b0857ee7d2410deaf215e23d1

All applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

      parent reply	other threads:[~2022-11-25  9:48 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-18 19:44 [PATCH v2 00/12] crypto: CFI fixes Eric Biggers
2022-11-18 19:44 ` [PATCH v2 01/12] crypto: x86/aegis128 - fix possible crash with CFI enabled Eric Biggers
2022-11-18 19:44 ` [PATCH v2 02/12] crypto: x86/aria - fix " Eric Biggers
2022-11-18 19:44 ` [PATCH v2 03/12] crypto: x86/nhpoly1305 - eliminate unnecessary CFI wrappers Eric Biggers
2022-11-18 19:44 ` [PATCH v2 04/12] crypto: x86/sha1 - fix possible crash with CFI enabled Eric Biggers
2022-11-18 19:44 ` [PATCH v2 05/12] crypto: x86/sha256 " Eric Biggers
2022-11-18 19:44 ` [PATCH v2 06/12] crypto: x86/sha512 " Eric Biggers
2022-11-18 19:44 ` [PATCH v2 07/12] crypto: x86/sm3 " Eric Biggers
2022-11-18 19:44 ` [PATCH v2 08/12] crypto: x86/sm4 - fix " Eric Biggers
2022-11-18 20:10   ` Eric Biggers
2022-11-18 20:27     ` Sami Tolvanen
2022-11-18 20:52       ` Eric Biggers
2022-11-18 20:53       ` Sami Tolvanen
2022-11-18 22:01         ` Sami Tolvanen
2022-11-18 22:33           ` Eric Biggers
2022-11-18 19:44 ` [PATCH v2 09/12] crypto: arm64/nhpoly1305 - eliminate unnecessary CFI wrapper Eric Biggers
2022-11-18 19:44 ` [PATCH v2 10/12] crypto: arm64/sm3 - fix possible crash with CFI enabled Eric Biggers
2022-11-18 19:44 ` [PATCH v2 11/12] crypto: arm/nhpoly1305 - eliminate unnecessary CFI wrapper Eric Biggers
2022-11-18 19:44 ` [PATCH v2 12/12] Revert "crypto: shash - avoid comparing pointers to exported functions under CFI" Eric Biggers
2022-11-25  9:46 ` Herbert Xu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y4CO2C6QatznTz5i@gondor.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=ebiggers@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=samitolvanen@google.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox