From: Eric Biggers <ebiggers@kernel.org>
To: Vladis Dronov <vdronov@redhat.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
"David S . Miller" <davem@davemloft.net>,
Nicolai Stange <nstange@suse.de>,
Elliott Robert <elliott@hpe.com>,
Stephan Mueller <smueller@chronox.de>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 6/6] crypto: testmgr - allow ecdsa-nist-p256 and -p384 in FIPS mode
Date: Thu, 29 Dec 2022 13:01:54 -0800 [thread overview]
Message-ID: <Y64AQg+W0SGsYUDY@sol.localdomain> (raw)
In-Reply-To: <20221229203708.13628-7-vdronov@redhat.com>
On Thu, Dec 29, 2022 at 09:37:08PM +0100, Vladis Dronov wrote:
> From: Nicolai Stange <nstange@suse.de>
>
> The kernel provides implementations of the NIST ECDSA signature
> verification primitives. For key sizes of 256 and 384 bits respectively
> they are approved and can be enabled in FIPS mode. Do so.
>
> Signed-off-by: Nicolai Stange <nstange@suse.de>
> Signed-off-by: Vladis Dronov <vdronov@redhat.com>
> Reviewed-by: Eric Biggers <ebiggers@google.com>
Please don't add my Reviewed-by to patches I didn't review. I only gave
Reviewed-by on "[PATCH 2/6] crypto: xts - drop xts_check_key()". I didn't look
at the other patches in the series much, as I'm not very interested in them.
- Eric
next prev parent reply other threads:[~2022-12-29 21:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-29 20:37 [PATCH v2 0/6] Trivial set of FIPS 140-3 related changes Vladis Dronov
2022-12-29 20:37 ` [PATCH v2 1/6] crypto: xts - restrict key lengths to approved values in FIPS mode Vladis Dronov
2022-12-29 20:37 ` [PATCH v2 2/6] crypto: xts - drop xts_check_key() Vladis Dronov
2022-12-29 20:37 ` [PATCH v2 3/6] crypto: xts - drop redundant xts key check Vladis Dronov
2022-12-29 20:37 ` [PATCH v2 4/6] crypto: testmgr - disallow plain cbcmac(aes) in FIPS mode Vladis Dronov
2022-12-29 20:37 ` [PATCH v2 5/6] crypto: testmgr - disallow plain ghash " Vladis Dronov
2022-12-29 20:37 ` [PATCH v2 6/6] crypto: testmgr - allow ecdsa-nist-p256 and -p384 " Vladis Dronov
2022-12-29 21:01 ` Eric Biggers [this message]
2022-12-29 21:15 ` Vladis Dronov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y64AQg+W0SGsYUDY@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=davem@davemloft.net \
--cc=elliott@hpe.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nstange@suse.de \
--cc=smueller@chronox.de \
--cc=vdronov@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox