From: Eric Biggers <ebiggers@kernel.org>
To: "Mothershead, Hailey" <hailmo@amazon.com>
Cc: "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
Subject: Re: [PATCH] crypto: jitterentropy - change back to module_init()
Date: Mon, 19 Apr 2021 12:57:23 -0700 [thread overview]
Message-ID: <YH3go6m2ypOWo5pw@gmail.com> (raw)
In-Reply-To: <4C32DE1B-7EED-432F-8BAE-4BA890ADAACC@amazon.com>
On Mon, Apr 19, 2021 at 04:16:13AM +0000, Mothershead, Hailey wrote:
> Hello,
>
> The patch quoted below causes the kernel to panic when fips is enabled with:
>
> alg: ecdh: test failed on vector 2, err=-14
> Kernel panic - not syncing: alg: self-tests for ecdh-generic (ecdh) failed in fips mode!
>
> This test fails because jitterentropy hasn’t been initialized yet. The assumption that the patch makes, that jitter is not used by the crypto self-tests, does not hold with fips enabled.
>
> With the patch reverted, i.e. with jitter initialized with module_init, the kernel is able to boot. How can this best be handled to allow the kernel to boot with fips enabled without running into issues with certain clocksources?
>
> Best,
> Hailey
I'd recommend looking into why the self-tests would be calling into
jitterentropy in the first place. That shouldn't be necessary; it doesn't make
sense for known-answer tests to be consuming random numbers.
- Eric
next prev parent reply other threads:[~2021-04-19 19:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <9A0645BD-E7B0-4A7B-BB8F-80C5616502FE@amazon.com>
[not found] ` <5289E5EC-C15F-44EB-BC5F-C5A515FFF272@amazon.com>
2021-04-19 4:16 ` [PATCH] crypto: jitterentropy - change back to module_init() Mothershead, Hailey
2021-04-19 19:57 ` Eric Biggers [this message]
2019-05-21 18:34 crypto: run initcalls for generic implementations earlier Eric Biggers
2019-05-21 18:46 ` [PATCH] crypto: jitterentropy - change back to module_init() Eric Biggers
2019-05-22 7:21 ` Geert Uytterhoeven
2019-05-30 13:42 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YH3go6m2ypOWo5pw@gmail.com \
--to=ebiggers@kernel.org \
--cc=hailmo@amazon.com \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).