From: Eric Biggers <ebiggers@kernel.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: linux-crypto@vger.kernel.org, linux-fscrypt@vger.kernel.org,
"Theodore Y. Ts'o" <tytso@mit.edu>,
Jaegeuk Kim <jaegeuk@kernel.org>,
Ard Biesheuvel <ardb@kernel.org>
Subject: Re: [PATCH v2 1/2] fscrypt: relax Kconfig dependencies for crypto API algorithms
Date: Wed, 21 Apr 2021 11:18:05 -0700 [thread overview]
Message-ID: <YIBsXY5QOcEjnZ6I@gmail.com> (raw)
In-Reply-To: <20210421075511.45321-2-ardb@kernel.org>
On Wed, Apr 21, 2021 at 09:55:10AM +0200, Ard Biesheuvel wrote:
> Even if FS encryption has strict functional dependencies on various
> crypto algorithms and chaining modes. those dependencies could potentially
> be satisified by other implementations than the generic ones, and no link
> time dependency exists on the 'depends on' claused defined by
> CONFIG_FS_ENCRYPTION_ALGS.
>
> So let's relax these clauses to 'imply', so that the default behavior
> is still to pull in those generic algorithms, but in a way that permits
> them to be disabled again in Kconfig.
>
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> ---
Acked-by: Eric Biggers <ebiggers@google.com>
Herbert, is there still time for you to take these two patches through the
crypto tree for 5.13? There aren't any other fscrypt or fsverity patches for
5.13, so that would be easiest for me.
- Eric
next prev parent reply other threads:[~2021-04-21 18:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 7:55 [PATCH v2 0/2] relax crypto Kconfig dependencies for fsverity/fscrypt Ard Biesheuvel
2021-04-21 7:55 ` [PATCH v2 1/2] fscrypt: relax Kconfig dependencies for crypto API algorithms Ard Biesheuvel
2021-04-21 18:18 ` Eric Biggers [this message]
2021-04-22 0:01 ` Herbert Xu
2021-04-21 7:55 ` [PATCH v2 2/2] fsverity: relax build time dependency on CRYPTO_SHA256 Ard Biesheuvel
2021-04-22 7:48 ` [PATCH v2 0/2] relax crypto Kconfig dependencies for fsverity/fscrypt Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YIBsXY5QOcEjnZ6I@gmail.com \
--to=ebiggers@kernel.org \
--cc=ardb@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=jaegeuk@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-fscrypt@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox