From: Eric Biggers <ebiggers@kernel.org>
To: Liu Shixin <liushixin2@huawei.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] crypto: remove CRYPTOA_U32 and related functions
Date: Thu, 10 Jun 2021 16:00:46 -0700 [thread overview]
Message-ID: <YMKZnrwYQVF7ttYw@gmail.com> (raw)
In-Reply-To: <20210605053902.2017295-1-liushixin2@huawei.com>
On Sat, Jun 05, 2021 at 01:39:02PM +0800, Liu Shixin wrote:
> According to the advice of Eric and Herbert, type CRYPTOA_U32
> has been unused for over a decade, so remove the code related to
> CRYPTOA_U32.
>
> After removing CRYPTOA_U32, the type of the variable attrs can be
> changed from union to struct.
>
> Signed-off-by: Liu Shixin <liushixin2@huawei.com>
> ---
> crypto/algapi.c | 18 ------------------
> crypto/algboss.c | 32 +++++++-------------------------
> include/crypto/algapi.h | 1 -
> include/linux/crypto.h | 5 -----
> 4 files changed, 7 insertions(+), 49 deletions(-)
Reviewed-by: Eric Biggers <ebiggers@google.com>
One nit below:
> + param->attrs[i].attr.rta_len =
> + sizeof(param->attrs[i]);
These two lines can be joined into one.
- Eric
prev parent reply other threads:[~2021-06-10 23:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-05 5:39 [PATCH -next] crypto: remove CRYPTOA_U32 and related functions Liu Shixin
2021-06-10 23:00 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMKZnrwYQVF7ttYw@gmail.com \
--to=ebiggers@kernel.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liushixin2@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).