Re: [PATCH Part1 RFC v4 23/36] KVM: x86: move lookup of indexed CPUID leafs to helper

Borislav Petkov
2021-08-19T10:07:25Z

On Wed, Jul 07, 2021 at 01:14:53PM -0500, Brijesh Singh wrote:
> From: Michael Roth <michael.roth@amd.com>
>
> Determining which CPUID leafs have significant ECX/index values is
> also needed by guest kernel code when doing SEV-SNP-validated CPUID
> lookups. Move this to common code to keep future updates in sync.
>
> Signed-off-by: Michael Roth <michael.roth@amd.com>
> Signed-off-by: Brijesh Singh <brijesh.singh@amd.com>
> ---
> arch/x86/include/asm/cpuid-indexed.h | 26 ++++++++++++++++++++++++++
> arch/x86/kvm/cpuid.c | 17 ++---------------
> 2 files changed, 28 insertions(+), 15 deletions(-)
> create mode 100644 arch/x86/include/asm/cpuid-indexed.h
>
> diff --git a/arch/x86/include/asm/cpuid-indexed.h b/arch/x86/include/asm/cpuid-indexed.h
> new file mode 100644
> index 000000000000..f5ab746f5712
> --- /dev/null
> +++ b/arch/x86/include/asm/cpuid-indexed.h

Just call it arch/x86/include/asm/cpuid.h

And if you feel bored, you can move the cpuid* primitives from
asm/processor.h to it, in another patch so that processor.h gets
slimmer.

Thx.

--
Regards/Gruss,
Boris.