From: Ben Boeckel <me@benboeckel.net>
To: Colin King <colin.king@canonical.com>
Cc: David Howells <dhowells@redhat.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S . Miller" <davem@davemloft.net>,
keyrings@vger.kernel.org, linux-crypto@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Randy Dunlap <rdunlap@infradead.org>
Subject: Re: [PATCH] crypto : asymmetric_keys: Fix function description to match prototype
Date: Wed, 6 Oct 2021 13:41:38 -0400 [thread overview]
Message-ID: <YV3f0gTu/epdCX/E@erythro.dev.benboeckel.internal> (raw)
In-Reply-To: <20211006172350.1025091-1-colin.king@canonical.com>
On Wed, Oct 06, 2021 at 18:23:50 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The function arguments in the description does not match the prototype.
> Fix this by renaming trust_keys to trusted_keys.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> crypto/asymmetric_keys/verify_pefile.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/crypto/asymmetric_keys/verify_pefile.c b/crypto/asymmetric_keys/verify_pefile.c
> index 7553ab18db89..148cad70fe79 100644
> --- a/crypto/asymmetric_keys/verify_pefile.c
> +++ b/crypto/asymmetric_keys/verify_pefile.c
> @@ -387,7 +387,7 @@ static int pefile_digest_pe(const void *pebuf, unsigned int pelen,
> * verify_pefile_signature - Verify the signature on a PE binary image
> * @pebuf: Buffer containing the PE binary image
> * @pelen: Length of the binary image
> - * @trust_keys: Signing certificate(s) to use as starting points
> + * @trusted_keys: Signing certificate(s) to use as starting points
> * @usage: The use to which the key is being put.
> *
> * Validate that the certificate chain inside the PKCS#7 message inside the PE
FYI, this was submitted earlier this week with Message-Id:
20211004001731.26240-1-rdunlap@infradead.org
which also fixes the `Return:` notation for the return value docs.
--Ben
next prev parent reply other threads:[~2021-10-06 17:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-06 17:23 [PATCH] crypto : asymmetric_keys: Fix function description to match prototype Colin King
2021-10-06 17:41 ` Ben Boeckel [this message]
2021-10-06 17:45 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YV3f0gTu/epdCX/E@erythro.dev.benboeckel.internal \
--to=me@benboeckel.net \
--cc=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=kernel-janitors@vger.kernel.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox