From: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
To: kernel test robot <lkp@intel.com>
Cc: herbert@gondor.apana.org.au, kbuild-all@lists.01.org,
linux-crypto@vger.kernel.org, qat-linux@intel.com,
marco.chiappero@intel.com
Subject: Re: [PATCH 13/24] crypto: qat - add pfvf_ops
Date: Fri, 12 Nov 2021 10:20:00 +0000 [thread overview]
Message-ID: <YY4/0D3CzOhkjiXr@silpixa00400314> (raw)
In-Reply-To: <202111121744.tlN4jsRt-lkp@intel.com>
On Fri, Nov 12, 2021 at 05:43:10PM +0800, kernel test robot wrote:
> Hi Giovanni,
>
> Thank you for the patch! Yet something to improve:
Thanks. I identified the issue and I'm going to send a V2 of the set.
--
Giovanni
>
> [auto build test ERROR on herbert-cryptodev-2.6/master]
> [also build test ERROR on herbert-crypto-2.6/master linus/master next-20211112]
> [cannot apply to v5.15]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
>
> url: https://github.com/0day-ci/linux/commits/Giovanni-Cabiddu/crypto-qat-PFVF-refactoring/20211111-045418
> base: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
> config: x86_64-randconfig-a002-20210928 (attached as .config)
> compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
> reproduce (this is a W=1 build):
> # https://github.com/0day-ci/linux/commit/3c769abfb3bc46aebd23323b3ed4ac36216dd51a
> git remote add linux-review https://github.com/0day-ci/linux
> git fetch --no-tags linux-review Giovanni-Cabiddu/crypto-qat-PFVF-refactoring/20211111-045418
> git checkout 3c769abfb3bc46aebd23323b3ed4ac36216dd51a
> # save the attached .config to linux build tree
> mkdir build_dir
> make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
> ld: drivers/crypto/qat/qat_dh895xcc/adf_dh895xcc_hw_data.o: in function `disable_vf2pf_interrupts':
> >> drivers/crypto/qat/qat_dh895xcc/adf_dh895xcc_hw_data.c:151: undefined reference to `adf_gen2_disable_vf2pf_interrupts'
> ld: drivers/crypto/qat/qat_dh895xcc/adf_dh895xcc_hw_data.o: in function `enable_vf2pf_interrupts':
> >> drivers/crypto/qat/qat_dh895xcc/adf_dh895xcc_hw_data.c:137: undefined reference to `adf_gen2_enable_vf2pf_interrupts'
> ld: drivers/crypto/qat/qat_dh895xcc/adf_dh895xcc_hw_data.o: in function `get_vf2pf_sources':
> >> drivers/crypto/qat/qat_dh895xcc/adf_dh895xcc_hw_data.c:120: undefined reference to `adf_gen2_get_vf2pf_sources'
>
>
> vim +151 drivers/crypto/qat/qat_dh895xcc/adf_dh895xcc_hw_data.c
>
> 22e4dda06dd0fa2 Allan, Bruce W 2015-01-09 115
> 993161d36ab5f0f Marco Chiappero 2021-09-28 116 static u32 get_vf2pf_sources(void __iomem *pmisc_bar)
> 993161d36ab5f0f Marco Chiappero 2021-09-28 117 {
> 993161d36ab5f0f Marco Chiappero 2021-09-28 118 u32 errsou5, errmsk5, vf_int_mask;
> 993161d36ab5f0f Marco Chiappero 2021-09-28 119
> 993161d36ab5f0f Marco Chiappero 2021-09-28 @120 vf_int_mask = adf_gen2_get_vf2pf_sources(pmisc_bar);
> 993161d36ab5f0f Marco Chiappero 2021-09-28 121
> 993161d36ab5f0f Marco Chiappero 2021-09-28 122 /* Get the interrupt sources triggered by VFs, but to avoid duplicates
> 993161d36ab5f0f Marco Chiappero 2021-09-28 123 * in the work queue, clear vf_int_mask_sets bits that are already
> 993161d36ab5f0f Marco Chiappero 2021-09-28 124 * masked in ERRMSK register.
> 993161d36ab5f0f Marco Chiappero 2021-09-28 125 */
> 993161d36ab5f0f Marco Chiappero 2021-09-28 126 errsou5 = ADF_CSR_RD(pmisc_bar, ADF_GEN2_ERRSOU5);
> 993161d36ab5f0f Marco Chiappero 2021-09-28 127 errmsk5 = ADF_CSR_RD(pmisc_bar, ADF_GEN2_ERRMSK5);
> 993161d36ab5f0f Marco Chiappero 2021-09-28 128 vf_int_mask |= ADF_DH895XCC_ERR_REG_VF2PF_U(errsou5);
> 993161d36ab5f0f Marco Chiappero 2021-09-28 129 vf_int_mask &= ~ADF_DH895XCC_ERR_REG_VF2PF_U(errmsk5);
> 993161d36ab5f0f Marco Chiappero 2021-09-28 130
> 993161d36ab5f0f Marco Chiappero 2021-09-28 131 return vf_int_mask;
> 993161d36ab5f0f Marco Chiappero 2021-09-28 132 }
> 993161d36ab5f0f Marco Chiappero 2021-09-28 133
> 993161d36ab5f0f Marco Chiappero 2021-09-28 134 static void enable_vf2pf_interrupts(void __iomem *pmisc_addr, u32 vf_mask)
> 993161d36ab5f0f Marco Chiappero 2021-09-28 135 {
> 993161d36ab5f0f Marco Chiappero 2021-09-28 136 /* Enable VF2PF Messaging Ints - VFs 0 through 15 per vf_mask[15:0] */
> 993161d36ab5f0f Marco Chiappero 2021-09-28 @137 adf_gen2_enable_vf2pf_interrupts(pmisc_addr, vf_mask);
> 993161d36ab5f0f Marco Chiappero 2021-09-28 138
> 993161d36ab5f0f Marco Chiappero 2021-09-28 139 /* Enable VF2PF Messaging Ints - VFs 16 through 31 per vf_mask[31:16] */
> 993161d36ab5f0f Marco Chiappero 2021-09-28 140 if (vf_mask >> 16) {
> 993161d36ab5f0f Marco Chiappero 2021-09-28 141 u32 val = ADF_CSR_RD(pmisc_addr, ADF_GEN2_ERRMSK5)
> 993161d36ab5f0f Marco Chiappero 2021-09-28 142 & ~ADF_DH895XCC_ERR_MSK_VF2PF_U(vf_mask);
> 993161d36ab5f0f Marco Chiappero 2021-09-28 143
> 993161d36ab5f0f Marco Chiappero 2021-09-28 144 ADF_CSR_WR(pmisc_addr, ADF_GEN2_ERRMSK5, val);
> 993161d36ab5f0f Marco Chiappero 2021-09-28 145 }
> 993161d36ab5f0f Marco Chiappero 2021-09-28 146 }
> 993161d36ab5f0f Marco Chiappero 2021-09-28 147
> 993161d36ab5f0f Marco Chiappero 2021-09-28 148 static void disable_vf2pf_interrupts(void __iomem *pmisc_addr, u32 vf_mask)
> 993161d36ab5f0f Marco Chiappero 2021-09-28 149 {
> 993161d36ab5f0f Marco Chiappero 2021-09-28 150 /* Disable VF2PF interrupts for VFs 0 through 15 per vf_mask[15:0] */
> 993161d36ab5f0f Marco Chiappero 2021-09-28 @151 adf_gen2_disable_vf2pf_interrupts(pmisc_addr, vf_mask);
> 993161d36ab5f0f Marco Chiappero 2021-09-28 152
> 993161d36ab5f0f Marco Chiappero 2021-09-28 153 /* Disable VF2PF interrupts for VFs 16 through 31 per vf_mask[31:16] */
> 993161d36ab5f0f Marco Chiappero 2021-09-28 154 if (vf_mask >> 16) {
> 993161d36ab5f0f Marco Chiappero 2021-09-28 155 u32 val = ADF_CSR_RD(pmisc_addr, ADF_GEN2_ERRMSK5)
> 993161d36ab5f0f Marco Chiappero 2021-09-28 156 | ADF_DH895XCC_ERR_MSK_VF2PF_U(vf_mask);
> 993161d36ab5f0f Marco Chiappero 2021-09-28 157
> 993161d36ab5f0f Marco Chiappero 2021-09-28 158 ADF_CSR_WR(pmisc_addr, ADF_GEN2_ERRMSK5, val);
> 993161d36ab5f0f Marco Chiappero 2021-09-28 159 }
> 993161d36ab5f0f Marco Chiappero 2021-09-28 160 }
> 993161d36ab5f0f Marco Chiappero 2021-09-28 161
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
next prev parent reply other threads:[~2021-11-12 10:20 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-10 20:51 [PATCH 00/24] crypto: qat - PFVF refactoring Giovanni Cabiddu
2021-11-10 20:51 ` [PATCH 01/24] crypto: qat - fix undetected PFVF timeout in ACK loop Giovanni Cabiddu
2021-11-10 20:51 ` [PATCH 02/24] crypto: qat - refactor PF top half for PFVF Giovanni Cabiddu
2021-11-10 20:51 ` [PATCH 03/24] crypto: qat - move vf2pf interrupt helpers Giovanni Cabiddu
2021-11-10 20:51 ` [PATCH 04/24] crypto: qat - move VF message handler to adf_vf2pf_msg.c Giovanni Cabiddu
2021-11-10 20:51 ` [PATCH 05/24] crypto: qat - move interrupt code out of the PFVF handler Giovanni Cabiddu
2021-11-10 20:51 ` [PATCH 06/24] crypto: qat - change PFVF ACK behaviour Giovanni Cabiddu
2021-11-10 20:52 ` [PATCH 07/24] crypto: qat - re-enable interrupts for legacy PFVF messages Giovanni Cabiddu
2021-11-10 20:52 ` [PATCH 08/24] crypto: qat - split PFVF message decoding from handling Giovanni Cabiddu
2021-11-10 20:52 ` [PATCH 09/24] crypto: qat - handle retries due to collisions in adf_iov_putmsg() Giovanni Cabiddu
2021-11-10 20:52 ` [PATCH 10/24] crypto: qat - relocate PFVF PF related logic Giovanni Cabiddu
2021-11-10 20:52 ` [PATCH 11/24] crypto: qat - relocate PFVF VF " Giovanni Cabiddu
2021-11-10 20:52 ` [PATCH 12/24] crypto: qat - relocate PFVF disabled function Giovanni Cabiddu
2021-11-10 20:52 ` [PATCH 13/24] crypto: qat - add pfvf_ops Giovanni Cabiddu
2021-11-12 9:43 ` kernel test robot
2021-11-12 10:20 ` Giovanni Cabiddu [this message]
2021-11-10 20:52 ` [PATCH 14/24] crypto: qat - differentiate between pf2vf and vf2pf offset Giovanni Cabiddu
2021-11-10 20:52 ` [PATCH 15/24] crypto: qat - abstract PFVF send function Giovanni Cabiddu
2021-11-10 20:52 ` [PATCH 16/24] crypto: qat - abstract PFVF receive logic Giovanni Cabiddu
2021-11-10 20:52 ` [PATCH 17/24] crypto: qat - reorganize PFVF code Giovanni Cabiddu
2021-11-10 20:52 ` [PATCH 18/24] crypto: qat - reorganize PFVF protocol definitions Giovanni Cabiddu
2021-11-10 20:52 ` [PATCH 19/24] crypto: qat - use enums for PFVF protocol codes Giovanni Cabiddu
2021-11-10 20:52 ` [PATCH 20/24] crypto: qat - pass the PF2VF responses back to the callers Giovanni Cabiddu
2021-11-10 20:52 ` [PATCH 21/24] crypto: qat - refactor pfvf version request messages Giovanni Cabiddu
2021-11-10 20:52 ` [PATCH 22/24] crypto: qat - do not rely on min version Giovanni Cabiddu
2021-11-10 20:52 ` [PATCH 23/24] crypto: qat - fix VF IDs in PFVF log messages Giovanni Cabiddu
2021-11-10 20:52 ` [PATCH 24/24] crypto: qat - improve logging of PFVF messages Giovanni Cabiddu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YY4/0D3CzOhkjiXr@silpixa00400314 \
--to=giovanni.cabiddu@intel.com \
--cc=herbert@gondor.apana.org.au \
--cc=kbuild-all@lists.01.org \
--cc=linux-crypto@vger.kernel.org \
--cc=lkp@intel.com \
--cc=marco.chiappero@intel.com \
--cc=qat-linux@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox