From: Borislav Petkov <bp@alien8.de>
To: Cristian Marussi <cristian.marussi@arm.com>
Cc: LKML <linux-kernel@vger.kernel.org>, linux-crypto@vger.kernel.org
Subject: Re: [PATCH v0 39/42] crypto: ccree - check notifier registration return value
Date: Fri, 12 Nov 2021 19:48:17 +0100 [thread overview]
Message-ID: <YY628XtLN+IH8D6J@zn.tnic> (raw)
In-Reply-To: <20211112183233.GB6655@e120937-lin>
On Fri, Nov 12, 2021 at 06:32:33PM +0000, Cristian Marussi wrote:
> Looking at the implementation of atomic_notifier_chain_register() and
> its internal helper down below, I can see that atomic_notifier_chain_register()
> ALWAYS return 0 (O_o) and anyway there is a WARN() in the notifiier core already
> to alert of double registrations.
You can ignore it - we agreed (at least no one has complained against it
yet :)) on doing this instead:
https://lore.kernel.org/r/YYk1xi3eJdMJdjHC@zn.tnic
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2021-11-12 18:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20211108101157.15189-1-bp@alien8.de>
2021-11-08 10:11 ` [PATCH v0 39/42] crypto: ccree - check notifier registration return value Borislav Petkov
2021-11-12 18:32 ` Cristian Marussi
2021-11-12 18:48 ` Borislav Petkov [this message]
2021-11-08 10:11 ` [PATCH v0 42/42] notifier: Return an error when callback is already registered Borislav Petkov
2021-11-08 14:07 ` Geert Uytterhoeven
2021-11-08 14:21 ` Borislav Petkov
2021-11-08 15:25 ` Geert Uytterhoeven
2021-11-08 15:58 ` Borislav Petkov
2021-11-08 16:12 ` Geert Uytterhoeven
2021-11-08 16:21 ` Borislav Petkov
2021-11-08 20:59 ` Alan Stern
2021-11-08 21:18 ` Borislav Petkov
2021-11-08 10:19 ` [PATCH v0 00/42] notifiers: " Borislav Petkov
2021-11-08 14:17 ` Alan Stern
2021-11-08 14:24 ` Borislav Petkov
2021-11-08 14:35 ` Borislav Petkov
2021-11-08 16:23 ` Steven Rostedt
2021-11-08 16:29 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YY628XtLN+IH8D6J@zn.tnic \
--to=bp@alien8.de \
--cc=cristian.marussi@arm.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox