* [PATCH] crypto: cleanup warning in qm_get_qos_value()
@ 2021-12-21 20:59 trix
2021-12-21 21:31 ` Nathan Chancellor
2021-12-22 1:44 ` Zhou Wang
0 siblings, 2 replies; 4+ messages in thread
From: trix @ 2021-12-21 20:59 UTC (permalink / raw)
To: wangzhou1, herbert, davem, nathan, ndesaulniers
Cc: linux-crypto, linux-kernel, llvm, Tom Rix
From: Tom Rix <trix@redhat.com>
Building with clang static analysis returns this warning:
qm.c:4382:11: warning: The left operand of '==' is a garbage value
if (*val == 0 || *val > QM_QOS_MAX_VAL || ret) {
~~~~ ^
The call to qm_qos_value_init() can return an error without setting
*val. So check ret before checking *val.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/crypto/hisilicon/qm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/hisilicon/qm.c b/drivers/crypto/hisilicon/qm.c
index b1fe9c7b8cc89..c906f2e59277b 100644
--- a/drivers/crypto/hisilicon/qm.c
+++ b/drivers/crypto/hisilicon/qm.c
@@ -4379,7 +4379,7 @@ static ssize_t qm_get_qos_value(struct hisi_qm *qm, const char *buf,
return -EINVAL;
ret = qm_qos_value_init(val_buf, val);
- if (*val == 0 || *val > QM_QOS_MAX_VAL || ret) {
+ if (ret || *val == 0 || *val > QM_QOS_MAX_VAL) {
pci_err(qm->pdev, "input qos value is error, please set 1~1000!\n");
return -EINVAL;
}
--
2.26.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] crypto: cleanup warning in qm_get_qos_value()
2021-12-21 20:59 [PATCH] crypto: cleanup warning in qm_get_qos_value() trix
@ 2021-12-21 21:31 ` Nathan Chancellor
2021-12-22 14:46 ` Tom Rix
2021-12-22 1:44 ` Zhou Wang
1 sibling, 1 reply; 4+ messages in thread
From: Nathan Chancellor @ 2021-12-21 21:31 UTC (permalink / raw)
To: trix
Cc: wangzhou1, herbert, davem, ndesaulniers, linux-crypto,
linux-kernel, llvm
On Tue, Dec 21, 2021 at 12:59:53PM -0800, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> Building with clang static analysis returns this warning:
>
> qm.c:4382:11: warning: The left operand of '==' is a garbage value
> if (*val == 0 || *val > QM_QOS_MAX_VAL || ret) {
> ~~~~ ^
>
> The call to qm_qos_value_init() can return an error without setting
> *val. So check ret before checking *val.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Should this have a fixes tag?
Fixes: 72b010dc33b9 ("crypto: hisilicon/qm - supports writing QoS int the host")
> ---
> drivers/crypto/hisilicon/qm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/hisilicon/qm.c b/drivers/crypto/hisilicon/qm.c
> index b1fe9c7b8cc89..c906f2e59277b 100644
> --- a/drivers/crypto/hisilicon/qm.c
> +++ b/drivers/crypto/hisilicon/qm.c
> @@ -4379,7 +4379,7 @@ static ssize_t qm_get_qos_value(struct hisi_qm *qm, const char *buf,
> return -EINVAL;
>
> ret = qm_qos_value_init(val_buf, val);
> - if (*val == 0 || *val > QM_QOS_MAX_VAL || ret) {
> + if (ret || *val == 0 || *val > QM_QOS_MAX_VAL) {
> pci_err(qm->pdev, "input qos value is error, please set 1~1000!\n");
> return -EINVAL;
> }
> --
> 2.26.3
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] crypto: cleanup warning in qm_get_qos_value()
2021-12-21 21:31 ` Nathan Chancellor
@ 2021-12-22 14:46 ` Tom Rix
0 siblings, 0 replies; 4+ messages in thread
From: Tom Rix @ 2021-12-22 14:46 UTC (permalink / raw)
To: Nathan Chancellor
Cc: wangzhou1, herbert, davem, ndesaulniers, linux-crypto,
linux-kernel, llvm
On 12/21/21 1:31 PM, Nathan Chancellor wrote:
> On Tue, Dec 21, 2021 at 12:59:53PM -0800, trix@redhat.com wrote:
>> From: Tom Rix <trix@redhat.com>
>>
>> Building with clang static analysis returns this warning:
>>
>> qm.c:4382:11: warning: The left operand of '==' is a garbage value
>> if (*val == 0 || *val > QM_QOS_MAX_VAL || ret) {
>> ~~~~ ^
>>
>> The call to qm_qos_value_init() can return an error without setting
>> *val. So check ret before checking *val.
>>
>> Signed-off-by: Tom Rix <trix@redhat.com>
> Reviewed-by: Nathan Chancellor <nathan@kernel.org>
>
> Should this have a fixes tag?
I was debating that, the existing if-check will catch this, just not as
efficiently.
I'll add the line.
Tom
>
> Fixes: 72b010dc33b9 ("crypto: hisilicon/qm - supports writing QoS int the host")
>
>> ---
>> drivers/crypto/hisilicon/qm.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/crypto/hisilicon/qm.c b/drivers/crypto/hisilicon/qm.c
>> index b1fe9c7b8cc89..c906f2e59277b 100644
>> --- a/drivers/crypto/hisilicon/qm.c
>> +++ b/drivers/crypto/hisilicon/qm.c
>> @@ -4379,7 +4379,7 @@ static ssize_t qm_get_qos_value(struct hisi_qm *qm, const char *buf,
>> return -EINVAL;
>>
>> ret = qm_qos_value_init(val_buf, val);
>> - if (*val == 0 || *val > QM_QOS_MAX_VAL || ret) {
>> + if (ret || *val == 0 || *val > QM_QOS_MAX_VAL) {
>> pci_err(qm->pdev, "input qos value is error, please set 1~1000!\n");
>> return -EINVAL;
>> }
>> --
>> 2.26.3
>>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] crypto: cleanup warning in qm_get_qos_value()
2021-12-21 20:59 [PATCH] crypto: cleanup warning in qm_get_qos_value() trix
2021-12-21 21:31 ` Nathan Chancellor
@ 2021-12-22 1:44 ` Zhou Wang
1 sibling, 0 replies; 4+ messages in thread
From: Zhou Wang @ 2021-12-22 1:44 UTC (permalink / raw)
To: trix, herbert, davem, nathan, ndesaulniers
Cc: linux-crypto, linux-kernel, llvm
在 2021/12/22 4:59, trix@redhat.com 写道:
> From: Tom Rix <trix@redhat.com>
>
> Building with clang static analysis returns this warning:
>
> qm.c:4382:11: warning: The left operand of '==' is a garbage value
> if (*val == 0 || *val > QM_QOS_MAX_VAL || ret) {
> ~~~~ ^
>
> The call to qm_qos_value_init() can return an error without setting
> *val. So check ret before checking *val.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/crypto/hisilicon/qm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/hisilicon/qm.c b/drivers/crypto/hisilicon/qm.c
> index b1fe9c7b8cc89..c906f2e59277b 100644
> --- a/drivers/crypto/hisilicon/qm.c
> +++ b/drivers/crypto/hisilicon/qm.c
> @@ -4379,7 +4379,7 @@ static ssize_t qm_get_qos_value(struct hisi_qm *qm, const char *buf,
> return -EINVAL;
>
> ret = qm_qos_value_init(val_buf, val);
> - if (*val == 0 || *val > QM_QOS_MAX_VAL || ret) {
> + if (ret || *val == 0 || *val > QM_QOS_MAX_VAL) {
> pci_err(qm->pdev, "input qos value is error, please set 1~1000!\n");
> return -EINVAL;
> }
>
Should check return firstly, thanks.
Zhou
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-12-22 14:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-21 20:59 [PATCH] crypto: cleanup warning in qm_get_qos_value() trix
2021-12-21 21:31 ` Nathan Chancellor
2021-12-22 14:46 ` Tom Rix
2021-12-22 1:44 ` Zhou Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox