From: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Herbert Xu <herbert@gondor.apana.org.au>
Cc: Tomasz Kowalik <tomaszx.kowalik@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Marco Chiappero <marco.chiappero@intel.com>,
Fiona Trahe <fiona.trahe@intel.com>,
Wojciech Ziemba <wojciech.ziemba@intel.com>,
Mateuszx Potrola <mateuszx.potrola@intel.com>,
qat-linux@intel.com, linux-crypto@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] crypto: qat - fix a signedness bug in get_service_enabled()
Date: Tue, 11 Jan 2022 12:05:51 +0000 [thread overview]
Message-ID: <Yd1yn4FHaueG4Lv8@silpixa00400314> (raw)
In-Reply-To: <20220111071806.GD11243@kili>
On Tue, Jan 11, 2022 at 10:18:06AM +0300, Dan Carpenter wrote:
> The "ret" variable needs to be signed or there is an error message which
> will not be printed correctly.
>
> Fixes: 0cec19c761e5 ("crypto: qat - add support for compression for 4xxx")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks Dan.
Acked-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
@Herbert, there are 2 other (identical) patches in the list that fix the
same issue:
https://patchwork.kernel.org/project/linux-crypto/patch/YdWZm6QJAYbYTKAR@debian-BULLSEYE-live-builder-AMD64/
https://patchwork.kernel.org/project/linux-crypto/patch/20220105152005.43305-1-jiapeng.chong@linux.alibaba.com/
Since none of them made into the pull request for 5.17, I'm fine with
taking this one as it is the only one which contains the Fixes tag.
Regards,
--
Giovanni
next prev parent reply other threads:[~2022-01-11 12:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-11 7:18 [PATCH] crypto: qat - fix a signedness bug in get_service_enabled() Dan Carpenter
2022-01-11 12:05 ` Giovanni Cabiddu [this message]
2022-01-28 6:23 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yd1yn4FHaueG4Lv8@silpixa00400314 \
--to=giovanni.cabiddu@intel.com \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=fiona.trahe@intel.com \
--cc=herbert@gondor.apana.org.au \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=marco.chiappero@intel.com \
--cc=mateuszx.potrola@intel.com \
--cc=qat-linux@intel.com \
--cc=tomaszx.kowalik@intel.com \
--cc=wojciech.ziemba@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox