From: Eric Biggers <ebiggers@kernel.org>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
"Jason A. Donenfeld" <Jason@zx2c4.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Masahiro Yamada <masahiroy@kernel.org>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>
Subject: Re: [PATCH v7] lib/crypto: blake2s: include as built-in
Date: Wed, 5 Jan 2022 14:09:20 -0800 [thread overview]
Message-ID: <YdYXEBhc7vuY+GQW@gmail.com> (raw)
In-Reply-To: <CAMj1kXHS8Gr9wbbbzvX+7u7qk0bAhgTpQw-bEB5Y_gmrcJ8iGw@mail.gmail.com>
On Wed, Jan 05, 2022 at 11:01:04PM +0100, Ard Biesheuvel wrote:
> On Wed, 5 Jan 2022 at 22:53, Eric Biggers <ebiggers@kernel.org> wrote:
> >
> > On Tue, Jan 04, 2022 at 06:02:52PM +0100, Ard Biesheuvel wrote:
> > > The only downside here is that the ARM/x86 accelerated shashes and the
> > > generic shash now use the same core transform, right?
> >
> > I don't see how this is the case, given that crypto/blake2s_generic.c still uses
> > blake2s_compress_generic(), not blake2s_compress().
> >
>
> Ah ok, I stand corrected then.
>
> So what are your thoughts on this? Should we keep the shashes while
> they have no users?
I don't know. Removing unused stuff is good per se, but I wouldn't have
expected this to be something that is being considered here. It's not like this
is a "controversial" algorithm, blake2b is already supported, and there could be
users of it already (dm-integrity, dm-verity, AF_ALG, etc.). If this is going
to happen, then the acceptance criteria for new algorithms need to get *much*
stricter, so that algorithms aren't constantly being added and removed.
- Eric
prev parent reply other threads:[~2022-01-05 22:11 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-23 14:11 [PATCH v2 1/2] lib/crypto: blake2s: include as built-in Jason A. Donenfeld
2021-12-23 14:20 ` Ard Biesheuvel
2021-12-24 13:35 ` Greg KH
2021-12-25 9:26 ` Masahiro Yamada
2021-12-25 10:26 ` Ard Biesheuvel
2021-12-25 15:47 ` Masahiro Yamada
2021-12-27 13:43 ` Jason A. Donenfeld
2021-12-27 13:47 ` [PATCH v3] " Jason A. Donenfeld
2021-12-27 14:20 ` [PATCH v4] " Jason A. Donenfeld
2022-01-01 15:59 ` [PATCH v5] " Jason A. Donenfeld
2022-01-02 20:42 ` [PATCH v6] " Jason A. Donenfeld
2022-01-03 3:23 ` Herbert Xu
2022-01-03 3:45 ` Jason A. Donenfeld
2022-01-03 4:06 ` Herbert Xu
2022-01-03 11:57 ` Jason A. Donenfeld
2022-01-03 12:31 ` [PATCH v7] " Jason A. Donenfeld
2022-01-04 1:21 ` Herbert Xu
2022-01-04 17:02 ` Ard Biesheuvel
2022-01-04 17:04 ` Jason A. Donenfeld
2022-01-05 0:28 ` Herbert Xu
2022-01-05 21:53 ` Eric Biggers
2022-01-05 22:01 ` Ard Biesheuvel
2022-01-05 22:09 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YdYXEBhc7vuY+GQW@gmail.com \
--to=ebiggers@kernel.org \
--cc=Jason@zx2c4.com \
--cc=ardb@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).