From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4703DC43217 for ; Sat, 5 Feb 2022 08:23:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241301AbiBEIXj (ORCPT ); Sat, 5 Feb 2022 03:23:39 -0500 Received: from isilmar-4.linta.de ([136.243.71.142]:49414 "EHLO isilmar-4.linta.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235206AbiBEIXh (ORCPT ); Sat, 5 Feb 2022 03:23:37 -0500 X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES Received: from owl.dominikbrodowski.net (owl.brodo.linta [10.2.0.111]) by isilmar-4.linta.de (Postfix) with ESMTPSA id 6CB1020141E; Sat, 5 Feb 2022 08:23:35 +0000 (UTC) Received: by owl.dominikbrodowski.net (Postfix, from userid 1000) id 4E64B81211; Sat, 5 Feb 2022 08:22:50 +0100 (CET) Date: Sat, 5 Feb 2022 08:22:50 +0100 From: Dominik Brodowski To: Eric Biggers Cc: "Jason A . Donenfeld " , Theodore Ts'o , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] random: remove use_input_pool parameter from crng_reseed() Message-ID: References: <20220204221733.39411-1-ebiggers@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220204221733.39411-1-ebiggers@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Am Fri, Feb 04, 2022 at 02:17:33PM -0800 schrieb Eric Biggers: > From: Eric Biggers > > The primary_crng is always reseeded from the input_pool, while the NUMA > crngs are always reseeded from the primary_crng. Remove the redundant > 'use_input_pool' parameter from crng_reseed() and just directly check > whether the crng is the primary_crng. > > Signed-off-by: Eric Biggers Reviewed-by: Dominik Brodowski Thanks, Dominik