From: Dominik Brodowski <linux@dominikbrodowski.net>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
Eric Biggers <ebiggers@kernel.org>, Theodore Ts'o <tytso@mit.edu>
Subject: Re: [PATCH v3 4/5] random: always wake up entropy writers after extraction
Date: Sat, 5 Feb 2022 19:00:30 +0100 [thread overview]
Message-ID: <Yf67Ppx5yDothW6d@owl.dominikbrodowski.net> (raw)
In-Reply-To: <20220205160118.252698-5-Jason@zx2c4.com>
Am Sat, Feb 05, 2022 at 05:01:17PM +0100 schrieb Jason A. Donenfeld:
> Now that POOL_BITS == POOL_MIN_BITS, we must unconditionally wake up
> entropy writers after every extraction. Therefore there's no point of
> write_wakeup_threshold, so we can move it to the dustbin of unused
> compatibility sysctls. While we're at it, we can fix a small comparison
> where we were waking up after <= min rather than < min.
>
> Suggested-by: Eric Biggers <ebiggers@kernel.org>
> Cc: Theodore Ts'o <tytso@mit.edu>
> Cc: Dominik Brodowski <linux@dominikbrodowski.net>
> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Reviewed-by: Dominik Brodowski <linux@dominikbrodowski.net>
Thanks,
Dominik
next prev parent reply other threads:[~2022-02-05 18:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-05 16:01 [PATCH v3 0/5] random: use computational hash for entropy extraction, and related fixes Jason A. Donenfeld
2022-02-05 16:01 ` [PATCH v3 1/5] random: use computational hash for entropy extraction Jason A. Donenfeld
2022-02-05 16:01 ` [PATCH v3 2/5] random: simplify entropy debiting Jason A. Donenfeld
2022-02-05 16:01 ` [PATCH v3 3/5] random: use linear min-entropy accumulation crediting Jason A. Donenfeld
2022-02-05 16:01 ` [PATCH v3 4/5] random: always wake up entropy writers after extraction Jason A. Donenfeld
2022-02-05 18:00 ` Dominik Brodowski [this message]
2022-02-05 22:38 ` Jason A. Donenfeld
2022-02-05 16:01 ` [PATCH v3 5/5] random: make credit_entropy_bits() always safe Jason A. Donenfeld
2022-02-08 6:48 ` [PATCH v3 0/5] random: use computational hash for entropy extraction, and related fixes Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yf67Ppx5yDothW6d@owl.dominikbrodowski.net \
--to=linux@dominikbrodowski.net \
--cc=Jason@zx2c4.com \
--cc=ebiggers@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox