From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C108C433F5 for ; Wed, 2 Mar 2022 11:49:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241588AbiCBLuJ (ORCPT ); Wed, 2 Mar 2022 06:50:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47356 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234246AbiCBLuI (ORCPT ); Wed, 2 Mar 2022 06:50:08 -0500 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB50D457B7; Wed, 2 Mar 2022 03:49:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646221764; x=1677757764; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=v/8Z9henQ4GELSvmZeIpH0uJzq3nMVEvEH4YDo/BPMw=; b=MXdP8tTBhT+PXTOjsN53nzQUS4uBHl1QxGs+wwjdzbAgkqdefD0UVky8 YA409pcbyNFHRZcmLH6p23+RZ2l3SB7dWz4EzLKtpAK33O1oV24NOa0x4 AedXc4DCUsyiNmiSIWUYbjBROCaQN/bb6huk5egLSviZbhDAhW2GEhobj tGL/HQ4zXYLvr2kA21AbQlCpC8L3+2UnDYguOYGDnhxRzfYp1iwFvZmXr 3jawUKa2dddWM+Kk0tf2ZCXEzIGmlOIHALchPM7jdBy2P6+RfZ4Qj3o/K g3IecPoUn3qRFfEaIiOSmvi3igRj8R3QeRP+k7YsT7tspGE4+eap8unxH A==; X-IronPort-AV: E=McAfee;i="6200,9189,10273"; a="236892113" X-IronPort-AV: E=Sophos;i="5.90,148,1643702400"; d="scan'208";a="236892113" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Mar 2022 03:49:24 -0800 X-IronPort-AV: E=Sophos;i="5.90,148,1643702400"; d="scan'208";a="535358916" Received: from silpixa00400314.ir.intel.com (HELO silpixa00400314) ([10.237.222.76]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Mar 2022 03:49:22 -0800 Date: Wed, 2 Mar 2022 11:49:16 +0000 From: Giovanni Cabiddu To: Greg KH Cc: Herbert Xu , Linus Torvalds , Kyle Sanderson , Dave Chinner , qat-linux@intel.com, Linux-Kernal , linux-xfs , Linux Crypto Mailing List , device-mapper development Subject: Re: Intel QAT on A2SDi-8C-HLN4F causes massive data corruption with dm-crypt + xfs Message-ID: References: <20220219210354.GF59715@dread.disaster.area> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Research and Development Ireland Ltd - Co. Reg. #308263 - Collinstown Industrial Park, Leixlip, County Kildare - Ireland Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Hi Greg, On Wed, Mar 02, 2022 at 11:29:00AM +0100, Greg KH wrote: > On Tue, Mar 01, 2022 at 04:11:13PM +1200, Herbert Xu wrote: > > On Mon, Feb 28, 2022 at 05:12:20PM -0800, Linus Torvalds wrote: > > > > > > It sounds like it was incidental and almost accidental that it fixed > > > that thing, and nobody realized it should perhaps be also moved to > > > stable. > > > > Yes this was incidental. The patch in question fixes an issue in > > OOM situations where drivers that must allocate memory on each > > request may lead to dead-lock so it's not really targeted at qat. > > Ok, so what commits should I backport to kernels older than 5.10 to > resolve this? Is it possible to wait for a set that resolves the problem rather than backporting the patches that disables the use-case? I have a patchset that fixes the actual issue and we are doing an internal review before submission to the mailing list. I should be able to send a V1 out between today and tomorrow. If not, then these are the patches that should be backported: 7bcb2c99f8ed crypto: algapi - use common mechanism for inheriting flags 2eb27c11937e crypto: algapi - add NEED_FALLBACK to INHERITED_FLAGS fbb6cda44190 crypto: algapi - introduce the flag CRYPTO_ALG_ALLOCATES_MEMORY b8aa7dc5c753 crypto: drivers - set the flag CRYPTO_ALG_ALLOCATES_MEMORY cd74693870fb dm crypt: don't use drivers that have CRYPTO_ALG_ALLOCATES_MEMORY Herbert, correct me if I'm wrong here. Thanks, -- Giovanni