linux-crypto.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Corentin Labbe <clabbe.montjoie@gmail.com>
To: Gilad Ben-Yossef <gilad@benyossef.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
	Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
	Linux kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: [BUG] crypto: ccree: driver does not handle case where cryptlen = authsize =0
Date: Sun, 20 Feb 2022 20:26:31 +0100	[thread overview]
Message-ID: <YhKV55t90HWm6bhv@Red> (raw)
In-Reply-To: <CAOtvUMfy1fF35B2sfbOMui8n9Q4iCke9rgn5TiYMUMjd8gqHsA@mail.gmail.com>

Le Thu, Feb 17, 2022 at 09:38:10PM +0200, Gilad Ben-Yossef a écrit :
> So, I still do not have access to my Salvator-X board but I attempted
> a fix nevertheless and it does not seem to trigger new failures on the
> boards I do have so please give it a shot and let me know.
> 
> And thanks again for taking the time to report this!
> 
> Cheers,
> Gilad

Hello

While testing your patch for this problem, I saw another warning (unrelated with your patch):
[   34.061953] ------------[ cut here ]------------
[   34.066656] DMA-API: ccree e6601000.crypto: cacheline tracking EEXIST, overlapping mappings aren't supported
[   34.076555] WARNING: CPU: 3 PID: 475 at /home/clabbe/linux-next/kernel/dma/debug.c:571 add_dma_entry+0x1d0/0x288
[   34.086748] Modules linked in:
[   34.089809] CPU: 3 PID: 475 Comm: cryptomgr_test Tainted: G        W         5.17.0-rc3-next-20220210-00115-g1ca9f29d9780-dirty #25
[   34.101635] Hardware name: Renesas Salvator-X board based on r8a77950 (DT)
[   34.108508] pstate: 60000005 (nZCv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--)
[   34.115471] pc : add_dma_entry+0x1d0/0x288
[   34.119569] lr : add_dma_entry+0x1d0/0x288
[   34.123664] sp : ffff80000e3236f0
[   34.126976] x29: ffff80000e3236f0 x28: 0000000000000000 x27: 0000000000000000
[   34.134122] x26: 0000000000000000 x25: ffff80000b3c76c0 x24: ffff80000b3c7000
[   34.141267] x23: 0000000000000000 x22: 00000000ffffffef x21: ffff80000a8c1000
[   34.148410] x20: ffff0004c0b93f80 x19: ffff80000b320000 x18: ffffffffffffffff
[   34.155554] x17: 6c7265766f202c54 x16: 534958454520676e x15: 00000000000001fa
[   34.162697] x14: ffff80000e3233f0 x13: 00000000ffffffea x12: ffff80000b3bdda0
[   34.169840] x11: 0000000000000001 x10: 0000000000000001 x9 : ffff80000b3a5db8
[   34.176984] x8 : c0000000ffffefff x7 : 0000000000017fe8 x6 : ffff80000b3a5d60
[   34.184126] x5 : 0000000000057fa8 x4 : 0000000000000000 x3 : 00000000ffffefff
[   34.191269] x2 : ffff80000b34db38 x1 : 371dfc0f85526100 x0 : 0000000000000000
[   34.198411] Call trace:
[   34.200856]  add_dma_entry+0x1d0/0x288
[   34.204604]  debug_dma_map_sg+0x150/0x398
[   34.208615]  __dma_map_sg_attrs+0x9c/0x108
[   34.212717]  dma_map_sg_attrs+0x10/0x28
[   34.216554]  cc_map_sg+0x80/0x100
[   34.219875]  cc_map_cipher_request+0x170/0x3c8
[   34.224319]  cc_cipher_process+0x210/0xb58
[   34.228415]  cc_cipher_encrypt+0x2c/0x38
[   34.232338]  crypto_skcipher_encrypt+0x44/0x78
[   34.236786]  drbg_kcapi_sym_ctr+0xdc/0x1f8
[   34.240887]  drbg_ctr_generate+0x5c/0x98
[   34.244812]  drbg_kcapi_random+0xb4/0x260
[   34.248823]  alg_test_stdrng+0xf8/0x2b0
[   34.252661]  alg_test.part.29+0xb4/0x398
[   34.256583]  alg_test+0x48/0x78
[   34.259724]  cryptomgr_test+0x48/0x50
[   34.263386]  kthread+0x11c/0x128
[   34.266619]  ret_from_fork+0x10/0x20
[   34.270198] irq event stamp: 318
[   34.273424] hardirqs last  enabled at (317): [<ffff8000081300e0>] __up_console_sem+0x60/0x98
[   34.281869] hardirqs last disabled at (318): [<ffff800009bfbb18>] el1_dbg+0x28/0x90
[   34.289531] softirqs last  enabled at (314): [<ffff800008010550>] __do_softirq+0x4a8/0x5ec
[   34.297796] softirqs last disabled at (305): [<ffff8000080ab644>] irq_exit_rcu+0x18c/0x1b0
[   34.306061] ---[ end trace 0000000000000000 ]---

Regards

  reply	other threads:[~2022-02-20 19:26 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-09  9:57 [BUG] crypto: ccree: driver does not handle case where cryptlen = authsize =0 Corentin Labbe
2022-02-09 17:45 ` Gilad Ben-Yossef
2022-02-17 19:38   ` Gilad Ben-Yossef
2022-02-20 19:26     ` Corentin Labbe [this message]
2022-02-21 10:08       ` Gilad Ben-Yossef
2022-02-21 14:05         ` Corentin Labbe
2022-02-22  7:39           ` Gilad Ben-Yossef
2022-02-28  9:11             ` Gilad Ben-Yossef
2022-03-04 13:30               ` Corentin Labbe
2022-03-06 21:49                 ` Herbert Xu
2022-03-07  7:59                   ` Gilad Ben-Yossef
2022-03-07 10:48                     ` Corentin Labbe
2022-03-07 11:14                       ` Robin Murphy
2022-03-07 11:49                         ` Corentin Labbe
2022-03-07 11:59                           ` Gilad Ben-Yossef
2022-03-07 13:47                             ` Corentin Labbe
2022-03-07 12:17                         ` Gilad Ben-Yossef
2022-03-07 12:35                           ` Robin Murphy
2022-03-07 12:47                             ` Gilad Ben-Yossef
2022-03-07 13:03                               ` Robin Murphy
2022-03-07 13:12                                 ` Robin Murphy
2022-03-07 13:21                                   ` Gilad Ben-Yossef
2022-03-07 13:13                                 ` Gilad Ben-Yossef
2022-03-07 13:45                         ` Corentin Labbe
2022-03-07 13:53                           ` Gilad Ben-Yossef
2022-03-07 13:56                             ` Corentin Labbe
2022-03-07 14:00                               ` Gilad Ben-Yossef
2022-03-07 14:05                                 ` Corentin Labbe
2022-03-08  9:40                               ` Corentin Labbe
2022-03-09  6:49                                 ` Gilad Ben-Yossef
2022-03-07 12:24                       ` Gilad Ben-Yossef
2022-03-07 13:43                       ` Gilad Ben-Yossef

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YhKV55t90HWm6bhv@Red \
    --to=clabbe.montjoie@gmail.com \
    --cc=gilad@benyossef.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).