From: "Theodore Ts'o" <tytso@mit.edu>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Guenter Roeck <linux@roeck-us.net>,
Dominik Brodowski <linux@dominikbrodowski.net>,
Jann Horn <jannh@google.com>
Subject: Re: [PATCH] random: allow writes to /dev/urandom to influence fast init
Date: Wed, 23 Mar 2022 08:31:54 -0400 [thread overview]
Message-ID: <YjsTOsqiNaURZQLM@mit.edu> (raw)
In-Reply-To: <YjqbcQbYHCOpgqGg@zx2c4.com>
On Tue, Mar 22, 2022 at 10:00:49PM -0600, Jason A. Donenfeld wrote:
>
> Another variation on that would be to do what this current patch does,
> but only crng_pre_init_inject() on CAP_SYS_ADMIN. But this has the same
> pitfall of only working as intended at cnrg_init=0 but not crng_init=1.
> That's better than nothing, but it's not perfect, and it introduces that
> problem with RNDADDTOENTCNT.
Well, one could argue that "RNDADDTOENTCNT" is a problem that has
always been there, and it already requires CAP_SYS_ADMIN. So I'm not
sure it makes it any worse.
> > > And perhaps we might consider attempting to deprecate RNDADDTOENTCNT at
> > > some point in the future.
> >
> > That would be a good idea. :-)
>
> Oh cool, I'm glad you agree. Let's do that then. Have a preferred path?
> Maybe just a pr_once() saying not to use it?
Probably. We could get more aggressive (e.g., WARN), but the first
Google search on RNDADDTOENTCNT returned:
https://github.com/jumpnow/rndaddtoentcnt
So I'm now regretting not silently making it vanish a decade or more ago...
- Ted
next prev parent reply other threads:[~2022-03-23 12:32 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-22 19:14 [PATCH] random: allow writes to /dev/urandom to influence fast init Jason A. Donenfeld
2022-03-22 20:42 ` Linus Torvalds
2022-03-22 23:54 ` Jason A. Donenfeld
2022-03-23 2:15 ` David Laight
2022-03-23 2:50 ` Jason A. Donenfeld
2022-03-23 8:43 ` Rasmus Villemoes
2022-03-24 14:12 ` Jason A. Donenfeld
2022-03-23 11:45 ` David Laight
2022-03-23 3:35 ` Theodore Ts'o
2022-03-23 4:00 ` Jason A. Donenfeld
2022-03-23 12:31 ` Theodore Ts'o [this message]
2022-05-23 17:59 ` Pavel Machek
2022-03-23 4:30 ` Alex Xu (Hello71)
2022-03-23 4:47 ` Jason A. Donenfeld
2022-03-23 14:01 ` David Laight
2022-03-23 19:53 ` Jason A. Donenfeld
2022-03-24 18:01 ` Eric Biggers
2022-03-24 3:18 ` Jason A. Donenfeld
2022-03-24 16:28 ` Alex Xu (Hello71)
2022-03-24 17:20 ` Jason A. Donenfeld
2022-03-24 19:03 ` Alex Xu (Hello71)
2022-03-24 18:26 ` Eric Biggers
2022-03-24 18:31 ` Jason A. Donenfeld
2022-06-19 16:44 ` Pavel Machek
2022-03-24 19:53 ` Eric Biggers
2022-03-24 20:25 ` Jason A. Donenfeld
2022-06-19 16:56 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YjsTOsqiNaURZQLM@mit.edu \
--to=tytso@mit.edu \
--cc=Jason@zx2c4.com \
--cc=jannh@google.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=linux@roeck-us.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).