Re: [PATCH v5 6/8] crypto: x86/polyval: Add PCLMULQDQ accelerated implementation of POLYVAL

Eric Biggers
2022-05-02T18:08:28Z

On Sun, May 01, 2022 at 01:43:23PM -0700, Eric Biggers wrote:
> > diff --git a/include/crypto/polyval.h b/include/crypto/polyval.h
> > index b14c38aa9166..bf64fb6c665f 100644
> > --- a/include/crypto/polyval.h
> > +++ b/include/crypto/polyval.h
> > @@ -8,10 +8,19 @@
> > #ifndef _CRYPTO_POLYVAL_H
> > #define _CRYPTO_POLYVAL_H
> >
> > +#include <crypto/gf128mul.h>
>
> <crypto/gf128mul.h> doesn't appear to be needed here.
>

It looks like the issue is that this patch removes <crypto/gf128mul.h> from
crypto/polyval-generic.c. If you just don't do that, then it won't be needed
here.

- Eric