From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: Stafford Horne <shorne@gmail.com>,
Mikulas Patocka <mpatocka@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andy Shevchenko <andy@kernel.org>,
device-mapper development <dm-devel@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Mike Snitzer <msnitzer@redhat.com>,
Mimi Zohar <zohar@linux.ibm.com>,
Milan Broz <gmazyland@gmail.com>
Subject: Re: [PATCH v2] hex2bin: make the function hex_to_bin constant-time
Date: Wed, 4 May 2022 12:15:31 +0200 [thread overview]
Message-ID: <YnJSQ3jJyvhmIstD@zx2c4.com> (raw)
In-Reply-To: <YnJQXr3igEMTqY3+@smile.fi.intel.com>
On Wed, May 04, 2022 at 01:07:26PM +0300, Andy Shevchenko wrote:
> On Wed, May 04, 2022 at 11:57:29AM +0200, Jason A. Donenfeld wrote:
> > On Wed, May 04, 2022 at 11:42:27AM +0200, Jason A. Donenfeld wrote:
> > > So more likely is that this patch just helps unmask a real issue
> > > elsewhere -- linker, compiler, or register restoration after preemption.
> > > I don't think there's anything to do with regards to the patch of this
> > > thread, as it's clearly fine.
> >
> > The problem even goes away if I just add a nop...
>
> Alignment? Compiler bug? HW issue?
Probably one of those, yea. Removing the instruction addresses, the only
difference between the two compiles is: https://xn--4db.cc/Rrn8usaX/diff#line-440
So either there's some alignment going on here, a compiler thing I
haven't spotted yet, or some very fragile interrupt/preemption behavior
that's interacting with this, either on the kernel side or the QEMU
side.
(I've never touched real HW for this; I just got nerd sniped when
wondering why my wireguard CI was failing...)
Jason
next prev parent reply other threads:[~2022-05-04 10:15 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-24 20:54 [PATCH] hex2bin: make the function hex_to_bin constant-time Mikulas Patocka
2022-04-24 21:30 ` Joe Perches
2022-04-24 21:37 ` Linus Torvalds
2022-04-24 21:42 ` Linus Torvalds
2022-04-25 9:37 ` David Laight
2022-04-25 11:04 ` Mikulas Patocka
2022-04-25 12:59 ` David Laight
2022-04-25 13:33 ` Mikulas Patocka
2022-04-25 12:07 ` [PATCH v2] " Mikulas Patocka
2022-04-25 17:53 ` Linus Torvalds
2022-05-04 8:38 ` Stafford Horne
2022-05-04 8:57 ` Mikulas Patocka
2022-05-04 9:20 ` Andy Shevchenko
2022-05-04 9:47 ` Milan Broz
2022-05-04 9:50 ` Jason A. Donenfeld
2022-05-04 11:54 ` Mikulas Patocka
2022-05-04 9:42 ` Jason A. Donenfeld
2022-05-04 9:44 ` Jason A. Donenfeld
2022-05-04 9:57 ` Jason A. Donenfeld
2022-05-04 10:07 ` Andy Shevchenko
2022-05-04 10:15 ` Jason A. Donenfeld [this message]
2022-05-04 18:00 ` Linus Torvalds
2022-05-04 19:42 ` Jason A. Donenfeld
2022-05-04 19:51 ` Linus Torvalds
2022-05-04 20:00 ` Linus Torvalds
2022-05-04 20:12 ` Stafford Horne
2022-05-04 20:26 ` Linus Torvalds
2022-05-04 21:24 ` Linus Torvalds
2022-05-04 19:57 ` Stafford Horne
2022-05-04 20:10 ` Linus Torvalds
2022-05-04 20:38 ` Stafford Horne
2022-05-08 0:37 ` Stafford Horne
2022-05-11 12:17 ` Stafford Horne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnJSQ3jJyvhmIstD@zx2c4.com \
--to=jason@zx2c4.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=davem@davemloft.net \
--cc=dm-devel@redhat.com \
--cc=gmazyland@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=msnitzer@redhat.com \
--cc=shorne@gmail.com \
--cc=torvalds@linux-foundation.org \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).