From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Eric Biggers <ebiggers@kernel.org>
Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
Theodore Ts'o <tytso@mit.edu>
Subject: Re: [PATCH] random: do not pretend to handle premature next security model
Date: Sun, 15 May 2022 12:17:13 +0200 [thread overview]
Message-ID: <YoDTKTxrCXnIxDyJ@zx2c4.com> (raw)
In-Reply-To: <YoBNHEqeNahziJt5@sol.localdomain>
Hi Eric,
On Sat, May 14, 2022 at 05:45:16PM -0700, Eric Biggers wrote:
> On Wed, May 11, 2022 at 12:32:19PM +0200, Jason A. Donenfeld wrote:
> > Hi Eric,
> >
> > On Wed, May 11, 2022 at 01:09:13AM -0700, Eric Biggers wrote:
> > > A couple very minor comments:
> >
> > Thanks, will fix these.
> >
> > Jason
>
> Found one more:
>
> /*
> * Return whether the crng seed is considered to be sufficiently
> * old that a reseeding might be attempted.
>
> It should say "that a reseeding is needed", or something similar.
Ahh, since it's now unconditional. Nice catch. Fixed as you suggested.
Jason
prev parent reply other threads:[~2022-05-15 10:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-04 11:30 [PATCH] random: do not pretend to handle premature next security model Jason A. Donenfeld
2022-05-11 8:09 ` Eric Biggers
2022-05-11 10:32 ` Jason A. Donenfeld
2022-05-15 0:45 ` Eric Biggers
2022-05-15 10:17 ` Jason A. Donenfeld [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YoDTKTxrCXnIxDyJ@zx2c4.com \
--to=jason@zx2c4.com \
--cc=ebiggers@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox