From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Eric Biggers <ebiggers@kernel.org>
Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] crypto: make the sha1 library optional
Date: Mon, 11 Jul 2022 16:59:18 +0200 [thread overview]
Message-ID: <Ysw6xiuLmV4NuGsf@zx2c4.com> (raw)
In-Reply-To: <20220709211849.210850-3-ebiggers@kernel.org>
On Sat, Jul 09, 2022 at 02:18:49PM -0700, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> Since the Linux RNG no longer uses sha1_transform(), the SHA-1 library
> is no longer needed unconditionally. Make it possible to build the
> Linux kernel without the SHA-1 library by putting it behind a kconfig
> option, and selecting this new option from the kconfig options that gate
> the remaining users: CRYPTO_SHA1 for crypto/sha1_generic.c, BPF for
> kernel/bpf/core.c, and IPV6 for net/ipv6/addrconf.c.
>
> Unfortunately, since BPF is selected by NET, for now this can only make
> a difference for kernels built without networking support.
Seems like a step in the right direction, thanks.
Reviewed-by: Jason A. Donenfeld <Jason@zx2c4.com>
next prev parent reply other threads:[~2022-07-11 15:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-09 21:18 [PATCH 0/2] crypto: make the sha1 library optional Eric Biggers
2022-07-09 21:18 ` [PATCH 1/2] crypto: move lib/sha1.c into lib/crypto/ Eric Biggers
2022-07-11 14:58 ` Jason A. Donenfeld
2022-07-09 21:18 ` [PATCH 2/2] crypto: make the sha1 library optional Eric Biggers
2022-07-11 14:59 ` Jason A. Donenfeld [this message]
2022-07-11 18:03 ` Jakub Kicinski
2022-07-15 1:18 ` Alexei Starovoitov
2022-07-15 8:50 ` [PATCH 0/2] " Herbert Xu
2022-07-18 17:49 ` Randy Dunlap
2022-07-19 3:48 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ysw6xiuLmV4NuGsf@zx2c4.com \
--to=jason@zx2c4.com \
--cc=ebiggers@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).