From: Eric Biggers <ebiggers@kernel.org>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/3] crypto: lib - remove __HAVE_ARCH_CRYPTO_MEMNEQ
Date: Mon, 25 Jul 2022 17:51:20 -0700 [thread overview]
Message-ID: <Yt86iHqr8W96wL+8@sol.localdomain> (raw)
In-Reply-To: <Yt8UCsYkH3O6RnFd@zx2c4.com>
On Tue, Jul 26, 2022 at 12:07:06AM +0200, Jason A. Donenfeld wrote:
> On Mon, Jul 25, 2022 at 11:36:36AM -0700, Eric Biggers wrote:
> > From: Eric Biggers <ebiggers@google.com>
> >
> > No architecture actually defines this, so it's unneeded.
> >
> > Signed-off-by: Eric Biggers <ebiggers@google.com>
>
> Reviewed-by: Jason A. Donenfeld <Jason@zx2c4.com>
>
> Aside: out of curiosity, I wonder what was originally intended with
> this, which magic arch-specific instructions were thought to be
> potentially of aid.
The original commit (6bf37e5aa90f) says:
Similarly to kernel library string functions, leave an option for future
even further optimized architecture specific assembler implementations.
But so far no one has bothered. It's already optimized to use 'long' accesses,
so I wouldn't expect it to get much faster with assembly.
- Eric
next prev parent reply other threads:[~2022-07-26 0:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-25 18:36 [PATCH v3 0/3] crypto: lib - create utils module Eric Biggers
2022-07-25 18:36 ` [PATCH v3 1/3] crypto: lib - create utils module and move __crypto_memneq into it Eric Biggers
2022-07-25 22:10 ` Jason A. Donenfeld
2022-07-25 18:36 ` [PATCH v3 2/3] crypto: lib - move __crypto_xor into utils Eric Biggers
2022-07-25 22:09 ` Jason A. Donenfeld
2022-07-26 1:00 ` Eric Biggers
2022-07-26 13:46 ` Ard Biesheuvel
2022-08-26 4:44 ` Eric Biggers
2022-08-26 4:46 ` Herbert Xu
2022-08-26 4:48 ` Eric Biggers
2022-08-26 4:52 ` Herbert Xu
2022-08-26 5:07 ` Eric Biggers
2022-07-25 18:36 ` [PATCH v3 3/3] crypto: lib - remove __HAVE_ARCH_CRYPTO_MEMNEQ Eric Biggers
2022-07-25 22:07 ` Jason A. Donenfeld
2022-07-26 0:51 ` Eric Biggers [this message]
2022-08-19 10:59 ` [PATCH v3 0/3] crypto: lib - create utils module Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yt86iHqr8W96wL+8@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=Jason@zx2c4.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox