From: Herbert Xu <herbert@gondor.apana.org.au>
To: Jean Delvare <jdelvare@suse.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-crypto@vger.kernel.org,
Declan Murphy <declan.murphy@intel.com>,
Daniele Alessandrelli <daniele.alessandrelli@intel.com>,
Mark Gross <mgross@linux.intel.com>,
Prabhjot Khurana <prabhjot.khurana@intel.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] crypto: keembay-ocs - Drop obsolete dependency on COMPILE_TEST
Date: Fri, 19 Aug 2022 19:02:25 +0800 [thread overview]
Message-ID: <Yv9twQnbmqrLCDcV@gondor.apana.org.au> (raw)
In-Reply-To: <20220803224755.177de90e@endymion.delvare>
On Wed, Aug 03, 2022 at 10:47:55PM +0200, Jean Delvare wrote:
> Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it
> is possible to test-build any driver which depends on OF on any
> architecture by explicitly selecting OF. Therefore depending on
> COMPILE_TEST as an alternative is no longer needed.
>
> It is actually better to always build such drivers with OF enabled,
> so that the test builds are closer to how each driver will actually be
> built on its intended target. Building them without OF may not test
> much as the compiler will optimize out potentially large parts of the
> code. In the worst case, this could even pop false positive warnings.
> Dropping COMPILE_TEST here improves the quality of our testing and
> avoids wasting time on non-existent issues.
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Declan Murphy <declan.murphy@intel.com>
> Cc: Daniele Alessandrelli <daniele.alessandrelli@intel.com>
> Cc: Mark Gross <mgross@linux.intel.com>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: Prabhjot Khurana <prabhjot.khurana@intel.com>
> Cc: "David S. Miller" <davem@davemloft.net>
> ---
> drivers/crypto/keembay/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2022-08-19 11:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-03 20:47 [PATCH] crypto: keembay-ocs - Drop obsolete dependency on COMPILE_TEST Jean Delvare
2022-08-19 11:02 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yv9twQnbmqrLCDcV@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=daniele.alessandrelli@intel.com \
--cc=davem@davemloft.net \
--cc=declan.murphy@intel.com \
--cc=jdelvare@suse.de \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mgross@linux.intel.com \
--cc=prabhjot.khurana@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox