From: Greg KH <gregkh@linuxfoundation.org>
To: Eric Biggers <ebiggers@kernel.org>
Cc: Kai Ye <yekai13@huawei.com>,
herbert@gondor.apana.org.au, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org, wangzhou1@hisilicon.com,
liulongfang@huawei.com
Subject: Re: [PATCH v7 2/3] Documentation: add a isolation strategy sysfs node for uacce
Date: Thu, 1 Sep 2022 20:09:51 +0200 [thread overview]
Message-ID: <YxD1byMGE03R8YWT@kroah.com> (raw)
In-Reply-To: <YxDlOFYih5tQ37Av@sol.localdomain>
On Thu, Sep 01, 2022 at 10:00:40AM -0700, Eric Biggers wrote:
> On Thu, Sep 01, 2022 at 05:04:08PM +0200, Greg KH wrote:
> > On Sat, Aug 06, 2022 at 10:29:42AM +0800, Kai Ye wrote:
> > > Update documentation describing sysfs node that could help to
> > > configure isolation strategy for users in the user space. And
> > > describing sysfs node that could read the device isolated state.
> > >
> > > Signed-off-by: Kai Ye <yekai13@huawei.com>
> > > ---
> > > Documentation/ABI/testing/sysfs-driver-uacce | 26 ++++++++++++++++++++
> > > 1 file changed, 26 insertions(+)
> > >
> > > diff --git a/Documentation/ABI/testing/sysfs-driver-uacce b/Documentation/ABI/testing/sysfs-driver-uacce
> > > index 08f2591138af..e09fd160d3fa 100644
> > > --- a/Documentation/ABI/testing/sysfs-driver-uacce
> > > +++ b/Documentation/ABI/testing/sysfs-driver-uacce
> > > @@ -19,6 +19,32 @@ Contact: linux-accelerators@lists.ozlabs.org
> > > Description: Available instances left of the device
> > > Return -ENODEV if uacce_ops get_available_instances is not provided
> > >
> > > +What: /sys/class/uacce/<dev_name>/isolate_strategy
> > > +Date: Jul 2022
> >
> > July was a while ago, you sent this patch in August :(
> >
>
> Does the date in the sysfs documentation files serve any purpose besides making
> people have to update their patchsets every month?
>
> The kernel version number would be more useful to readers of the documentation,
> and it wouldn't have to be updated quite as often.
True, I have seen people use that instead, or no date at all, I don't
require it. But if you do put the field in there, it should at least be
correct :)
thanks,
greg k-h
next prev parent reply other threads:[~2022-09-01 18:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-06 2:29 [PATCH v7 0/3] crypto: hisilicon - supports device isolation feature Kai Ye
2022-08-06 2:29 ` [PATCH v7 1/3] uacce: " Kai Ye
2022-08-06 2:29 ` [PATCH v7 2/3] Documentation: add a isolation strategy sysfs node for uacce Kai Ye
2022-09-01 15:04 ` Greg KH
2022-09-01 17:00 ` Eric Biggers
2022-09-01 18:09 ` Greg KH [this message]
2022-09-05 12:02 ` yekai (A)
2022-08-06 2:29 ` [PATCH v7 3/3] crypto: hisilicon/qm - define the device isolation strategy Kai Ye
2022-08-22 3:38 ` [PATCH v7 0/3] crypto: hisilicon - supports device isolation feature yekai (A)
2022-08-29 10:57 ` yekai (A)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxD1byMGE03R8YWT@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=ebiggers@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liulongfang@huawei.com \
--cc=wangzhou1@hisilicon.com \
--cc=yekai13@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).