From: Herbert Xu <herbert@gondor.apana.org.au>
To: Peter Harliman Liem <pliem@maxlinear.com>
Cc: atenart@kernel.org, linux-crypto@vger.kernel.org,
linux-lgm-soc@maxlinear.com
Subject: Re: [PATCH v2 1/2] crypto: inside_secure - Avoid dma map if size is zero
Date: Wed, 7 Sep 2022 14:52:06 +0800 [thread overview]
Message-ID: <Yxg/lipSWadoeD6E@gondor.apana.org.au> (raw)
In-Reply-To: <de6de430fd9bbc2d38ff2d5a1ce89983421b9dda.1662432407.git.pliem@maxlinear.com>
On Tue, Sep 06, 2022 at 10:51:49AM +0800, Peter Harliman Liem wrote:
>
> diff --git a/drivers/crypto/inside-secure/safexcel_cipher.c b/drivers/crypto/inside-secure/safexcel_cipher.c
> index d68ef16650d4..3775497775e0 100644
> --- a/drivers/crypto/inside-secure/safexcel_cipher.c
> +++ b/drivers/crypto/inside-secure/safexcel_cipher.c
> @@ -737,14 +737,17 @@ static int safexcel_send_req(struct crypto_async_request *base, int ring,
> max(totlen_src, totlen_dst));
> return -EINVAL;
> }
> - dma_map_sg(priv->dev, src, sreq->nr_src, DMA_BIDIRECTIONAL);
> + if (sreq->nr_src > 0)
> + dma_map_sg(priv->dev, src, sreq->nr_src, DMA_BIDIRECTIONAL);
Where is the corresponding check on unmap?
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2022-09-07 6:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-06 2:51 [PATCH v2 1/2] crypto: inside_secure - Avoid dma map if size is zero Peter Harliman Liem
2022-09-06 2:51 ` [PATCH v2 2/2] crypto: inside-secure - Select CRYPTO_AES config Peter Harliman Liem
2022-09-06 14:05 ` Antoine Tenart
2022-09-07 6:46 ` Peter Harliman Liem
2022-09-07 8:48 ` Antoine Tenart
2022-09-23 2:39 ` Peter Harliman Liem
2022-09-06 14:00 ` [PATCH v2 1/2] crypto: inside_secure - Avoid dma map if size is zero Antoine Tenart
2022-09-07 6:43 ` Peter Harliman Liem
2022-09-07 6:52 ` Herbert Xu [this message]
2022-09-23 2:35 ` Peter Harliman Liem
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yxg/lipSWadoeD6E@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=atenart@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-lgm-soc@maxlinear.com \
--cc=pliem@maxlinear.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox