From: Dan Carpenter <dan.carpenter@oracle.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Boris Brezillon <bbrezillon@kernel.org>,
Arnaud Ebalard <arno@natisbad.org>,
Srujana Challa <schalla@marvell.com>,
"David S. Miller" <davem@davemloft.net>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Giovanni Cabiddu <giovanni.cabiddu@intel.com>,
Lukasz Bartosik <lbartosik@marvell.com>,
linux-crypto@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] crypto: marvell/octeontx - prevent integer overflows
Date: Thu, 15 Sep 2022 16:54:54 +0300 [thread overview]
Message-ID: <YyMurruKJH2TKhAR@kadam> (raw)
In-Reply-To: <Yxm3MuG+2hMdJSGB@gondor.apana.org.au>
On Thu, Sep 08, 2022 at 05:34:42PM +0800, Herbert Xu wrote:
> On Thu, Sep 01, 2022 at 06:32:09PM +0300, Dan Carpenter wrote:
> >
> > @@ -303,7 +304,13 @@ static int process_tar_file(struct device *dev,
> > if (get_ucode_type(ucode_hdr, &ucode_type))
> > return 0;
> >
> > - ucode_size = ntohl(ucode_hdr->code_length) * 2;
> > + code_length = ntohl(ucode_hdr->code_length);
> > + if (code_length >= INT_MAX / 2) {
> > + dev_err(dev, "Invalid code_length %u\n", code_length);
> > + return -EINVAL;
> > + }
> > +
> > + ucode_size = code_length * 2;
> > if (!ucode_size || (size < round_up(ucode_size, 16) +
> > sizeof(struct otx_cpt_ucode_hdr) + OTX_CPT_UCODE_SIGN_LEN)) {
> > dev_err(dev, "Ucode %s invalid size\n", filename);
>
> How come you didn't add a "ucode_size > size" check like you did
> below?
>
I'm really sorry. This was not my best work at all. The ucode_size
was a mistake. It should have just been the check against INT_MAX.
regards,
dan carpenter
prev parent reply other threads:[~2022-09-15 13:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-01 15:32 [PATCH] crypto: marvell/octeontx - prevent integer overflows Dan Carpenter
2022-09-08 9:34 ` Herbert Xu
2022-09-15 13:54 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YyMurruKJH2TKhAR@kadam \
--to=dan.carpenter@oracle.com \
--cc=arno@natisbad.org \
--cc=bbrezillon@kernel.org \
--cc=davem@davemloft.net \
--cc=giovanni.cabiddu@intel.com \
--cc=herbert@gondor.apana.org.au \
--cc=kernel-janitors@vger.kernel.org \
--cc=lbartosik@marvell.com \
--cc=linux-crypto@vger.kernel.org \
--cc=schalla@marvell.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).