From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Sven van Ashbrook <svenva@chromium.org>, linux@dominikbrodowski.net
Cc: LKML <linux-kernel@vger.kernel.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
Dominik Brodowski <linux@dominikbrodowski.net>,
Olivia Mackall <olivia@selenic.com>,
Alex Levin <levinale@google.com>,
Andrey Pronin <apronin@google.com>,
Stephen Boyd <swboyd@google.com>, Rajat Jain <rajatja@google.com>,
Eric Biggers <ebiggers@google.com>,
Petr Mladek <pmladek@suse.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Theodore Ts'o <tytso@mit.edu>,
linux-crypto@vger.kernel.org
Subject: Re: [PATCH v2 1/2] random: move add_hwgenerator_randomness()'s wait outside function
Date: Thu, 15 Sep 2022 16:43:54 +0100 [thread overview]
Message-ID: <YyNIOg1mtnzQz1H7@zx2c4.com> (raw)
In-Reply-To: <20220915002235.v2.1.I7c0a79e9b3c52584f5b637fde5f1d6f807605806@changeid>
Hi Sven,
On Thu, Sep 15, 2022 at 12:22:53AM +0000, Sven van Ashbrook wrote:
> add_hwgenerator_randomness() currently blocks until more entropy
> is needed. Move the blocking wait out of the function to the caller,
> by letting the function return the number of jiffies needed to block.
>
> This is done to prepare the function's sole kernel caller from a
> kthread to self-rearming delayed_work.
Isn't Dominik working on the same thing, but slightly different? I
recall he sent a patch recently, which looked pretty good, except it
just needed to be split up. I'm waiting for his v2. Does this build on
that?
Jason
next prev parent reply other threads:[~2022-09-15 15:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-15 0:22 [PATCH v2 1/2] random: move add_hwgenerator_randomness()'s wait outside function Sven van Ashbrook
2022-09-15 0:22 ` [PATCH v2 2/2] hwrng: core: fix suspend/resume race condition Sven van Ashbrook
2022-09-15 15:43 ` Jason A. Donenfeld [this message]
2022-09-15 18:54 ` [PATCH v2 1/2] random: move add_hwgenerator_randomness()'s wait outside function Sven van Ashbrook
2022-09-16 6:22 ` Dominik Brodowski
2022-09-16 14:24 ` Sven van Ashbrook
2022-09-16 14:50 ` Jason A. Donenfeld
2022-09-19 15:03 ` Sven van Ashbrook
2022-09-19 15:05 ` Jason A. Donenfeld
2022-09-19 17:19 ` Sven van Ashbrook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YyNIOg1mtnzQz1H7@zx2c4.com \
--to=jason@zx2c4.com \
--cc=apronin@google.com \
--cc=bigeasy@linutronix.de \
--cc=ebiggers@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=levinale@google.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=olivia@selenic.com \
--cc=pmladek@suse.com \
--cc=rajatja@google.com \
--cc=svenva@chromium.org \
--cc=swboyd@google.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox