From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Robin Murphy <robin.murphy@arm.com>
Cc: linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
Herbert Xu <herbert@gondor.apana.org.au>,
Corentin Labbe <clabbe@baylibre.com>,
Lin Jinhan <troy.lin@rock-chips.com>, wevsty <ty@wevs.org>,
Mikhail Rudenko <mike.rudenko@gmail.com>,
Heiko Stuebner <heiko@sntech.de>, Lin Huang <hl@rock-chips.com>,
Shawn Lin <shawn.lin@rock-chips.com>,
linux-rockchip@lists.infradead.org,
Kyle Copperfield <kmcopper@danwin1210.de>
Subject: Re: [PATCH] hw_random: rockchip: import driver from vendor tree
Date: Tue, 20 Sep 2022 11:49:02 +0200 [thread overview]
Message-ID: <YymMjpeHWV3d+64d@zx2c4.com> (raw)
In-Reply-To: <32f8797a-4b65-69df-ee8e-7891a6b4f1af@arm.com>
Hi Robin,
On Tue, Sep 20, 2022 at 10:35:44AM +0100, Robin Murphy wrote:
> On 2022-09-19 22:00, Jason A. Donenfeld wrote:
> > The Rockchip driver has long existed out of tree, but not upstream.
> > There is support for it upstream in u-boot, but not in Linux proper.
> > This commit imports the GPLv2 driver written by Lin Jinhan, together
> > with the DTS and config blobs from Wevsty.
>
> Note that Corentin has a series enabling the full crypto driver for
> RK3328 and RK3399[1], so it would seem more sensible to add TRNG support
> to that. Having confliciting compatibles for the same hardware that
> force the user to change their DT to choose one functionality or the
> other isn't good (plus there's also no binding for this one).
Kyle, CC'd, pointed out the same thing to me. He apparently has already
done the work to have a hwrng ontop of that series. So hopefully it's
just a matter of having everyone coordinate.
So I'll duck out and let you guys handle it. Just please make sure the
thing you're rejecting this for does actually come to fruition.
Kyle, should you send your thing to Corentin?
Jason
next prev parent reply other threads:[~2022-09-20 9:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-19 21:00 [PATCH] hw_random: rockchip: import driver from vendor tree Jason A. Donenfeld
2022-09-20 9:35 ` Robin Murphy
2022-09-20 9:49 ` Jason A. Donenfeld [this message]
2022-09-27 16:37 ` Aurelien Jarno
2022-09-27 19:46 ` LABBE Corentin
2022-09-27 21:39 ` Aurelien Jarno
2022-09-29 7:45 ` LABBE Corentin
2022-11-16 18:04 ` Mikhail Rudenko
2022-11-22 13:29 ` Corentin LABBE
2022-11-22 15:04 ` Mikhail Rudenko
2023-01-31 10:34 ` Corentin LABBE
2024-06-18 13:27 ` Anand Moon
2024-09-23 7:48 ` Janpieter Sollie
2024-09-25 15:01 ` Corentin LABBE
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YymMjpeHWV3d+64d@zx2c4.com \
--to=jason@zx2c4.com \
--cc=clabbe@baylibre.com \
--cc=heiko@sntech.de \
--cc=herbert@gondor.apana.org.au \
--cc=hl@rock-chips.com \
--cc=kmcopper@danwin1210.de \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mike.rudenko@gmail.com \
--cc=robin.murphy@arm.com \
--cc=shawn.lin@rock-chips.com \
--cc=troy.lin@rock-chips.com \
--cc=ty@wevs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).