From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CB3FC54EE9 for ; Tue, 27 Sep 2022 16:38:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229453AbiI0Qin (ORCPT ); Tue, 27 Sep 2022 12:38:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48692 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230482AbiI0Qil (ORCPT ); Tue, 27 Sep 2022 12:38:41 -0400 Received: from hall.aurel32.net (hall.aurel32.net [IPv6:2001:bc8:30d7:100::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 76E351DADFA; Tue, 27 Sep 2022 09:38:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=aurel32.net ; s=202004.hall; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Content-Transfer-Encoding:From:Reply-To: Subject:Content-ID:Content-Description:X-Debbugs-Cc; bh=ZOmyr0741p8HxTGKR6xPjn9bzOl726XtgNZYRB1MIBA=; b=pJfeAszpHyjtPAIdxlLZP1WikJ fT2HG5jhfVnW9TwE81qdTP44C7gBOorGItOT520Qfp0RDKuo+5e7pCeaMAHXYYYog++Bz7mHgOH0s 09MtkHD/XIVK7FN11JrQe6eh0NBeytdnzB5J4jjt9bTSPfsh1Jz5J5XgKMm7G5Bj/7n5VHIn640jk ujHunMzcOeq9VY7kasjXEO/ENa580J6Dwz3aj/NoAZPPQjguyBJYM+ItQE3MLNx3UpHtojBpHSqqa DT3BLu4PjL9t4D0xCHPXWnfUlnnfbych7z52KSXKCZZvuihr2HtfOPrkjMR7Tf52CaZgRYWNzlmxe zE/FMujw==; Received: from [2a01:e34:ec5d:a741:8a4c:7c4e:dc4c:1787] (helo=ohm.rr44.fr) by hall.aurel32.net with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1odDaj-00BrCg-TA; Tue, 27 Sep 2022 18:37:53 +0200 Received: from aurel32 by ohm.rr44.fr with local (Exim 4.96) (envelope-from ) id 1odDaj-000LPi-0p; Tue, 27 Sep 2022 18:37:53 +0200 Date: Tue, 27 Sep 2022 18:37:53 +0200 From: Aurelien Jarno To: Robin Murphy , "Jason A. Donenfeld" , linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, Herbert Xu , Corentin Labbe Cc: Lin Jinhan , wevsty , Mikhail Rudenko , Heiko Stuebner , Lin Huang , Shawn Lin , linux-rockchip@lists.infradead.org Subject: Re: [PATCH] hw_random: rockchip: import driver from vendor tree Message-ID: Mail-Followup-To: Robin Murphy , "Jason A. Donenfeld" , linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, Herbert Xu , Corentin Labbe , Lin Jinhan , wevsty , Mikhail Rudenko , Heiko Stuebner , Lin Huang , Shawn Lin , linux-rockchip@lists.infradead.org References: <20220919210025.2376254-1-Jason@zx2c4.com> <32f8797a-4b65-69df-ee8e-7891a6b4f1af@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <32f8797a-4b65-69df-ee8e-7891a6b4f1af@arm.com> User-Agent: Mutt/2.2.7 (2022-08-07) Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On 2022-09-20 10:35, Robin Murphy wrote: > On 2022-09-19 22:00, Jason A. Donenfeld wrote: > > The Rockchip driver has long existed out of tree, but not upstream. > > There is support for it upstream in u-boot, but not in Linux proper. > > This commit imports the GPLv2 driver written by Lin Jinhan, together > > with the DTS and config blobs from Wevsty. > > Note that Corentin has a series enabling the full crypto driver for > RK3328 and RK3399[1], so it would seem more sensible to add TRNG support > to that. Having confliciting compatibles for the same hardware that > force the user to change their DT to choose one functionality or the > other isn't good (plus there's also no binding for this one). It might make sense for the cryptov1-rng driver (I haven't checked). For the cryptov2-rng driver, I looked at the RK3568 TRM (I can't find the RK3588 one), and from what I understand crypto and TRNG are two different devices, using different address spaces, clock, reset and interrupts. The vendor kernel uses two different drivers. Regards Aurelien -- Aurelien Jarno GPG: 4096R/1DDD8C9B aurelien@aurel32.net http://www.aurel32.net