From: Lukas Wunner <lukas@wunner.de>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Ard Biesheuvel <ardb@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
Zorro Lang <zlang@redhat.com>,
Vegard Nossum <vegard.nossum@oracle.com>,
Joey Gouly <joey.gouly@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH for-next/fixes] arm64/mm: Fix false-positive !virt_addr_valid() for kernel image
Date: Fri, 29 Nov 2024 09:00:48 +0100 [thread overview]
Message-ID: <Z0l0sMgZPWpMlBXn@wunner.de> (raw)
In-Reply-To: <Z0SVYSew0gIgSdAe@J2N7QTR9R3>
On Mon, Nov 25, 2024 at 03:18:57PM +0000, Mark Rutland wrote:
> No; I meant that the test could use lm_alias() on the test vectors
> before passing those to sg_set_buf(), when the test code knows by
> construction that those vectors happen to be part of the kernel image.
> That'll work on all architectures.
Herbert doesn't want callers of the sign/verify API to do the mapping:
https://lore.kernel.org/linux-crypto/Z0A2W1FTTPt9PeI5@gondor.apana.org.au/
> That said, looking at the code it appears that testmgr.c can be built as
> a module, so the test vectors could be module/vmalloc addresses rather
> than virt/linear or image addresses. Given that, I don't think the
> changes suggested here are sufficient, as module addresses should still
> be rejected.
Ah, I hadn't considered the modular case. Good point!
Thanks for the explanation and for taking a look!
Lukas
prev parent reply other threads:[~2024-11-29 8:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-24 16:15 [PATCH for-next/fixes] arm64/mm: Fix false-positive !virt_addr_valid() for kernel image Lukas Wunner
2024-11-24 16:38 ` Ard Biesheuvel
2024-11-24 17:13 ` Ard Biesheuvel
2024-11-25 9:54 ` Lukas Wunner
2024-11-25 10:50 ` Mark Rutland
2024-11-25 14:49 ` Lukas Wunner
2024-11-25 15:18 ` Mark Rutland
2024-11-29 8:00 ` Lukas Wunner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z0l0sMgZPWpMlBXn@wunner.de \
--to=lukas@wunner.de \
--cc=ardb@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=herbert@gondor.apana.org.au \
--cc=joey.gouly@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=vegard.nossum@oracle.com \
--cc=will@kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox