From: Herbert Xu <herbert@gondor.apana.org.au>
To: Eric Biggers <ebiggers@kernel.org>
Cc: kernel test robot <lkp@intel.com>,
Danny Tsen <dtsen@linux.ibm.com>,
oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
Ard Biesheuvel <ardb@kernel.org>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>
Subject: Re: [PATCH] crypto: lib/Kconfig - Fix lib built-in failure when arch is modular
Date: Wed, 12 Feb 2025 13:29:11 +0800 [thread overview]
Message-ID: <Z6wxp7UE9MAht4pc@gondor.apana.org.au> (raw)
In-Reply-To: <20250212050936.GB2010357@google.com>
On Wed, Feb 12, 2025 at 05:09:36AM +0000, Eric Biggers wrote:
>
> Please name these like ARCH_HAS_CURVE25519 and CRYPTO_LIB_CURVE25519_ARCH to be
> consistent with the CRC library, the many other ARCH_HAS_* options, and
> CRYPTO_LIB_CURVE25519_GENERIC. Nothing uses names that contain "MAY_HAVE",
> which is ambiguous.
>
> FWIW, at some point the arch optimized crypto algorithms also need to just be
> enabled by default. The fact that they're not is a longstanding bug that is
> really harmful to users and needs to be fixed.
I'm simply responding to an lkp report. While your suggestions
may have merit, I don't have the time to pursue them.
Feel free to send patches if you wish.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2025-02-12 5:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <202501230223.ikroNDr1-lkp@intel.com>
2025-02-12 4:48 ` [PATCH] crypto: lib/Kconfig - Fix lib built-in failure when arch is modular Herbert Xu
2025-02-12 5:09 ` Eric Biggers
2025-02-12 5:29 ` Herbert Xu [this message]
2025-02-12 5:44 ` Eric Biggers
2025-02-12 5:48 ` Herbert Xu
[not found] ` <202502232152.JC84YDLp-lkp@intel.com>
2025-02-24 3:28 ` [PATCH] crypto: lib/Kconfig - Fix lib built-in and modular failure for arm64/mips/s390 Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6wxp7UE9MAht4pc@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=ardb@kernel.org \
--cc=dtsen@linux.ibm.com \
--cc=ebiggers@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox