From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-176.mta1.migadu.com (out-176.mta1.migadu.com [95.215.58.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 15E303FB0E for ; Wed, 26 Feb 2025 02:46:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740538021; cv=none; b=fYxZ40NnKxZcJMQ7l9Z3BuUnB651ITZTRZH8jhnJUAbNrE+cnFedI+XTEo1UBI6lT+G15lxvYhAm3MFWIOl7GzdHrqrHq80AnAJ7Fkr6vF/ayLAhBy+w3tk/bI42eF8mlLIdxNdibSSiX8nBuAJBLaSSZXIP4XivFTsol9iQVQc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740538021; c=relaxed/simple; bh=Ztaw/4iKvi4PfNHCK3e+9IS8E/GsOpzkRTl/ZUe1gZw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lAbQulbIKCLafRqzviPbBMMNcJlDFraSnHBATyqhpkfDuGQ6TTiE/YKsxFQ1S2BkbsaDkj5EvjnEjpNZQx8U6J0fIlJyQD2rqIFZjZIRIH+YIwX5ayv+yrcYpnHwmLfG9WZfLyLxvcLlwrwIf+skezYhbSAWPXmVBIMxrjud8dc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=QzYFiPnY; arc=none smtp.client-ip=95.215.58.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="QzYFiPnY" Date: Wed, 26 Feb 2025 02:46:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1740538018; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PNQREzBUoxFxQC1/e8FKtyGb+Q7/bb7nwwjKa99py3U=; b=QzYFiPnYne0hV2XOpE1d7tPmtG1cJziA1H08fMY70Pz58C0xPOCeYla7VgDTnkrOOGymDf hc3iZysvaUwRGDfWRzwfDDHBhq2GuQhiY6ZLvA3FWvmUlcvMdpNDcz8VZtHMMw4H11CgmF 5ae30sMl1UdWTExtrUhTmd9NDui1nJ0= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Yosry Ahmed To: Herbert Xu Cc: syzbot , davem@davemloft.net, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com, Andrew Morton , linux-mm@kvack.org Subject: Re: mm: zswap: fix crypto_free_acomp deadlock in zswap_cpu_comp_dead Message-ID: References: <67bcea51.050a0220.bbfd1.0096.GAE@google.com> <3482501981b13aedda3c1c6b54d83d496bd05922@linux.dev> Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT On Wed, Feb 26, 2025 at 10:10:22AM +0800, Herbert Xu wrote: > On Wed, Feb 26, 2025 at 02:08:14AM +0000, Yosry Ahmed wrote: > > > > Could you please: > > > > (1) Explain the exact scenario in the commit log, I did not understand > > it at first, only after looking at the syzbot dashboard for a while (and > > I am not sure how long this persists). > > > > (2) Move all the freeing operations outside the mutex? Right now > > crypto_free_acomp() was the problematic call but it could be > > acomp_request_free() next. > > > > Something like: > > Looks good to me. Feel free to send this patch since it is your > system after all :) Can do :) May I add your Co-developed-by and Signed-off-by since this would be based off your patch?