From: Herbert Xu <herbert@gondor.apana.org.au>
To: Eric Biggers <ebiggers@kernel.org>
Cc: Arnd Bergmann <arnd@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Will Deacon <will@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Catalin Marinas <catalin.marinas@arm.com>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Harald Freudenberger <freude@linux.ibm.com>,
Holger Dengler <dengler@linux.ibm.com>,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Ard Biesheuvel <ardb@kernel.org>,
"James E . J . Bottomley" <James.Bottomley@hansenpartnership.com>,
Jarkko Sakkinen <jarkko@kernel.org>,
linux-crypto@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org,
linux-s390@vger.kernel.org
Subject: Re: [PATCH] crypto: lib/Kconfig - Select and hide arch options
Date: Wed, 26 Feb 2025 16:31:36 +0800 [thread overview]
Message-ID: <Z77RaBFMc7u4EEIc@gondor.apana.org.au> (raw)
In-Reply-To: <20250226060725.GA41090@sol.localdomain>
On Tue, Feb 25, 2025 at 10:07:25PM -0800, Eric Biggers wrote:
>
> There's no need to have a select for every architecture, with the dependencies
> redundantly listed. Instead just 'default' each of the arch-optimized options
> to CRYPTO_LIB_CHACHA.
Good point.
> The way it should work is that CRYPTO_CHACHA20 should just select
> CRYPTO_LIB_CHACHA (and thus also the optimized code).
Good catch. I'll add them.
> And similarly for the other algorithms, which should be in their patches.
It's best to keep everything together as if done separately they
may introduce bisection issues between the patches.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2025-02-26 8:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-25 16:42 [PATCH] crypto: lib/Kconfig - fix chacha/poly1305 dependencies more more Arnd Bergmann
2025-02-25 21:33 ` Will Deacon
2025-02-25 21:40 ` Arnd Bergmann
2025-02-25 21:50 ` Arnd Bergmann
2025-02-26 1:40 ` Herbert Xu
2025-02-26 4:36 ` [PATCH] crypto: lib/Kconfig - Select and hide arch options Herbert Xu
2025-02-26 6:07 ` Eric Biggers
2025-02-26 8:31 ` Herbert Xu [this message]
2025-02-26 9:08 ` [v2 PATCH] crypto: lib/Kconfig - Hide arch options from user Herbert Xu
2025-02-27 7:48 ` [v3 " Herbert Xu
2025-02-27 8:32 ` Arnd Bergmann
2025-02-27 8:43 ` Herbert Xu
2025-02-27 11:56 ` Arnd Bergmann
2025-02-27 12:04 ` Ard Biesheuvel
2025-02-28 4:11 ` Herbert Xu
2025-02-28 17:10 ` Arnd Bergmann
2025-02-27 5:57 ` [PATCH] crypto: lib/Kconfig - Select and hide arch options kernel test robot
2025-02-27 6:29 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z77RaBFMc7u4EEIc@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=James.Bottomley@hansenpartnership.com \
--cc=agordeev@linux.ibm.com \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=borntraeger@linux.ibm.com \
--cc=catalin.marinas@arm.com \
--cc=davem@davemloft.net \
--cc=dengler@linux.ibm.com \
--cc=ebiggers@kernel.org \
--cc=freude@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=jarkko@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=svens@linux.ibm.com \
--cc=tsbogend@alpha.franken.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox