Re: [PATCH V3 5/6] tpm: Add a driver for Loongson TPM device

[Jarkko Sakkinen <jarkko@kernel.org>]

On Thu, Feb 20, 2025 at 07:23:42PM +0800, Qunqin Zhao wrote:
> 
> 在 2025/2/19 下午9:44, Jarkko Sakkinen 写道:
> > > +
> > > +static const struct tpm_class_ops lsse_tpm_ops = {
> > > +	.flags = TPM_OPS_AUTO_STARTUP,
> > > +	.recv = tpm_ls_recv,
> > > +	.send = tpm_ls_send,
> > > +};
> > > +
> > > +static int lsse_tpm_probe(struct platform_device *pdev)
> > tpm_lsse_
> OK.
> > +
> > +static struct platform_driver lsse_tpm_driver = {
> > +	.probe   = lsse_tpm_probe,
> > +	.driver  = {
> > +		.name  = "ls6000se-tpm",
> > +	},
> > +};
> > +module_platform_driver(lsse_tpm_driver);
> > +
> > +MODULE_ALIAS("platform:ls6000se-tpm");
> > +MODULE_LICENSE("GPL");
> > +MODULE_AUTHOR("Yinggang Gu <guyinggang@loongson.cn>");
> > +MODULE_AUTHOR("Qunqin Zhao <zhaoqunqin@loongson.cn>");
> > Remove MODULE_AUTHOR fields. Git encodes this already.
> 
> Do you mean that "modinfo" will still show the author after removing
> MODULE_AUTHOR fields?

What is the utility of showing that? Nobody ever updates those in real
life, so you really can't trust them anyhow. We're better of not showing
anything at all.

> 
> > 
> > > +MODULE_DESCRIPTION("Loongson TPM driver");
> > > -- 
> > > 2.43.0
> > > 
> > Prefix all with tpm_lsse instead of tpm
> 
> OK, thanks for your comments.
> 
> BR, Qunqin.
> 
> > 
> > BR, Jarkko
> 

BR, Jarkko