From: Herbert Xu <herbert@gondor.apana.org.au>
To: Eric Biggers <ebiggers@kernel.org>
Cc: linux-crypto@vger.kernel.org
Subject: Re: [PATCH] crypto: lib/chacha - remove unused arch-specific init support
Date: Fri, 21 Mar 2025 19:07:05 +0800 [thread overview]
Message-ID: <Z91IWeOoitS-nTA3@gondor.apana.org.au> (raw)
In-Reply-To: <20250316045747.249992-1-ebiggers@kernel.org>
Eric Biggers <ebiggers@kernel.org> wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> All implementations of chacha_init_arch() just call
> chacha_init_generic(), so it is pointless. Just delete it, and replace
> chacha_init() with what was previously chacha_init_generic().
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
> arch/arm/crypto/chacha-glue.c | 10 ++--------
> arch/arm64/crypto/chacha-neon-glue.c | 10 ++--------
> arch/mips/crypto/chacha-glue.c | 10 ++--------
> arch/powerpc/crypto/chacha-p10-glue.c | 10 ++--------
> arch/s390/crypto/chacha-glue.c | 8 +-------
> arch/x86/crypto/chacha_glue.c | 10 ++--------
> crypto/chacha_generic.c | 4 ++--
> include/crypto/chacha.h | 11 +----------
> tools/testing/crypto/chacha20-s390/test-cipher.c | 4 ++--
> 9 files changed, 16 insertions(+), 61 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2025-03-21 11:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-16 4:57 [PATCH] crypto: lib/chacha - remove unused arch-specific init support Eric Biggers
2025-03-16 8:24 ` Ard Biesheuvel
2025-03-21 11:07 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z91IWeOoitS-nTA3@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=ebiggers@kernel.org \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox