From: Herbert Xu <herbert@gondor.apana.org.au>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: linux-crypto@vger.kernel.org, ebiggers@kernel.org,
James Bottomley <James.Bottomley@hansenpartnership.com>
Subject: Re: [PATCH v2] crypto: lib - implement library version of AES in CFB mode
Date: Sat, 11 Mar 2023 17:00:42 +0800 [thread overview]
Message-ID: <ZAxDOhfuSTsgncMU@gondor.apana.org.au> (raw)
In-Reply-To: <CAMj1kXG_27v0YXoO_8Avjcz=YtYhCfX_6pcXowk0fy5cYR6gVw@mail.gmail.com>
On Sat, Mar 11, 2023 at 09:55:15AM +0100, Ard Biesheuvel wrote:
>
> That way, the implementations can remain the same,
That's like doing a house renovation and keeping the scaffold
around forever :)
Yes I agree that it would save a little bit of work for now but
all the implementations would have to carry this unnecessary
walking code with them forever.
With a setup like ahash/shash the walking code disappears totally
from the underlying implementations.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2023-03-11 9:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-17 14:43 [PATCH v2] crypto: lib - implement library version of AES in CFB mode Ard Biesheuvel
2023-02-20 4:44 ` Herbert Xu
2023-02-20 7:28 ` Ard Biesheuvel
2023-03-10 10:15 ` Herbert Xu
2023-03-10 16:18 ` Ard Biesheuvel
2023-03-11 8:06 ` Herbert Xu
2023-03-11 8:15 ` Ard Biesheuvel
2023-03-11 8:17 ` Herbert Xu
2023-03-11 8:42 ` Ard Biesheuvel
2023-03-11 8:47 ` Herbert Xu
2023-03-11 8:55 ` Ard Biesheuvel
2023-03-11 9:00 ` Herbert Xu [this message]
2023-03-11 9:02 ` Ard Biesheuvel
2023-03-11 9:21 ` Herbert Xu
2023-03-11 9:25 ` Ard Biesheuvel
2023-03-11 9:41 ` Herbert Xu
2023-03-12 8:06 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAxDOhfuSTsgncMU@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=James.Bottomley@hansenpartnership.com \
--cc=ardb@kernel.org \
--cc=ebiggers@kernel.org \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).