From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E807C6FD20 for ; Fri, 24 Mar 2023 10:04:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229508AbjCXKEV (ORCPT ); Fri, 24 Mar 2023 06:04:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59796 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229536AbjCXKEV (ORCPT ); Fri, 24 Mar 2023 06:04:21 -0400 Received: from 167-179-156-38.a7b39c.syd.nbn.aussiebb.net (167-179-156-38.a7b39c.syd.nbn.aussiebb.net [167.179.156.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C70B1A49F; Fri, 24 Mar 2023 03:04:20 -0700 (PDT) Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1pfeH8-008FBY-Ov; Fri, 24 Mar 2023 18:03:59 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Fri, 24 Mar 2023 18:03:58 +0800 Date: Fri, 24 Mar 2023 18:03:58 +0800 From: Herbert Xu To: Ard Biesheuvel Cc: Krzysztof Kozlowski , "David S. Miller" , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] crypto - img-hash: Drop of_match_ptr for ID table Message-ID: References: <20230310223027.315954-1-krzysztof.kozlowski@linaro.org> <20230310223027.315954-2-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Thu, Mar 23, 2023 at 09:43:58AM +0100, Ard Biesheuvel wrote: > > No. PRP0001 support in ACPI does not depend on OF, so drivers that may > be bound to such devices should not either. > > If you are concerned about the memory used by such tables, you can > always propose making PRP0001 support configurable in the ACPI core, > but making individual devices depend on OF for PRP0001 matching seems > wrong to me. What I am against is removing of_match_ptr by doing a million tiny patches. Either we should keep it, in which case the of_match_table field should be made conditional on OF or perhaps a new Kconfig option if there is no way to reconcile this with ACPI, or we decide to get rid of it and you should do one giant patch to remove of_match_ptr across the kernel tree. We should not be doing a patch for every single driver that has of_match_table based on whether it can or cannot be used through ACPI. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt