public inbox for linux-crypto@vger.kernel.org
 help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Scott Mayhew <smayhew@redhat.com>, Ard Biesheuvel <ardb@kernel.org>
Cc: linux-crypto@vger.kernel.org, chuck.lever@oracle.com,
	linux-nfs@vger.kernel.org
Subject: Re: RPCSEC GSS krb5 KUnit test fails on arm64 with h/w accelerated ciphers enabled
Date: Fri, 28 Apr 2023 17:44:18 +0800	[thread overview]
Message-ID: <ZEuVcizjPtG96/ST@gondor.apana.org.au> (raw)
In-Reply-To: <ZEBi8ReG9LKLcmW3@aion.usersys.redhat.com>

Scott Mayhew <smayhew@redhat.com> wrote:
>
> diff --git a/arch/arm64/crypto/aes-modes.S b/arch/arm64/crypto/aes-modes.S
> index 0e834a2c062c..477605fad76b 100644
> --- a/arch/arm64/crypto/aes-modes.S
> +++ b/arch/arm64/crypto/aes-modes.S
> @@ -268,6 +268,7 @@ AES_FUNC_START(aes_cbc_cts_encrypt)
>        add             x4, x0, x4
>        st1             {v0.16b}, [x4]                  /* overlapping stores */
>        st1             {v1.16b}, [x0]
> +       st1             {v1.16b}, [x5]
>        ret
> AES_FUNC_END(aes_cbc_cts_encrypt)
> 
> But I don't know if that change is at all correct! (I've never even
> looked at arm64 asm before).  If someone who's knowledgeable about this
> code could chime in, I'd appreciate it.

Ard, could you please take a look at this?

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

  reply	other threads:[~2023-04-28  9:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-19 21:53 RPCSEC GSS krb5 KUnit test fails on arm64 with h/w accelerated ciphers enabled Scott Mayhew
2023-04-28  9:44 ` Herbert Xu [this message]
2023-04-28  9:57   ` Ard Biesheuvel
2023-04-28 12:59     ` Chuck Lever III
2023-04-28 16:09       ` Ard Biesheuvel
2023-04-28 16:18         ` Chuck Lever III
2023-04-28 16:48           ` Ard Biesheuvel
2023-04-28 23:46             ` Eric Biggers
2023-05-01 13:02             ` Scott Mayhew

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZEuVcizjPtG96/ST@gondor.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=ardb@kernel.org \
    --cc=chuck.lever@oracle.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=smayhew@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox