From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F625EB64DA for ; Fri, 14 Jul 2023 08:58:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235713AbjGNI6W (ORCPT ); Fri, 14 Jul 2023 04:58:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33652 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235717AbjGNI6V (ORCPT ); Fri, 14 Jul 2023 04:58:21 -0400 Received: from 167-179-156-38.a7b39c.syd.nbn.aussiebb.net (167-179-156-38.a7b39c.syd.nbn.aussiebb.net [167.179.156.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98AF02713; Fri, 14 Jul 2023 01:58:20 -0700 (PDT) Received: from gwarestrin.arnor.me.apana.org.au ([192.168.103.7]) by fornost.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1qKEcw-001RhJ-1C; Fri, 14 Jul 2023 18:58:15 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 14 Jul 2023 18:58:07 +1000 Date: Fri, 14 Jul 2023 18:58:07 +1000 From: Herbert Xu To: Martin Kaiser Cc: linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] hwrng: imx-rngc - use dev_err_probe Message-ID: References: <20230704170644.69669-1-martin@kaiser.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230704170644.69669-1-martin@kaiser.cx> Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, Jul 04, 2023 at 07:06:44PM +0200, Martin Kaiser wrote: > Simplify the code by calling dev_err_probe instead of dev_err and return. > > While at it, use the same device for all error messages. > > Signed-off-by: Martin Kaiser > --- > drivers/char/hw_random/imx-rngc.c | 24 ++++++++---------------- > 1 file changed, 8 insertions(+), 16 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt