From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34B9BC7112B for ; Fri, 18 Aug 2023 08:52:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358761AbjHRIvg (ORCPT ); Fri, 18 Aug 2023 04:51:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55812 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1358771AbjHRIvN (ORCPT ); Fri, 18 Aug 2023 04:51:13 -0400 Received: from 167-179-156-38.a7b39c.syd.nbn.aussiebb.net (167-179-156-38.a7b39c.syd.nbn.aussiebb.net [167.179.156.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0641430E6; Fri, 18 Aug 2023 01:51:12 -0700 (PDT) Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1qWvCD-005EnG-5I; Fri, 18 Aug 2023 16:51:06 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Fri, 18 Aug 2023 16:51:05 +0800 Date: Fri, 18 Aug 2023 16:51:05 +0800 From: Herbert Xu To: Andy Shevchenko Cc: Lucas Segarra Fernandez , linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, qat-linux@intel.com, alx.manpages@gmail.com, Giovanni Cabiddu Subject: Re: [PATCH 4/4] crypto: qat - add pm_status debugfs file Message-ID: References: <20230817143352.132583-1-lucas.segarra.fernandez@intel.com> <20230817143352.132583-5-lucas.segarra.fernandez@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Fri, Aug 18, 2023 at 11:46:55AM +0300, Andy Shevchenko wrote: > > Splitting ARRAY_SIZE() is very beneficial on its own. > The static assert is slightly more robust for the big code then defining > something that at some point can be missed or miscalculated. Yet we can > survive with a macro if you thinks it's better. Yes please go ahead with just a macro. If the ARRYA_SIZE thing turns out to be useful for other people I'm sure it'll be added. But I don't see much value in this particular use. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt