From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58C88C83F16 for ; Tue, 29 Aug 2023 10:19:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235055AbjH2KSq (ORCPT ); Tue, 29 Aug 2023 06:18:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37128 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235099AbjH2KSf (ORCPT ); Tue, 29 Aug 2023 06:18:35 -0400 Received: from 167-179-156-38.a7b39c.syd.nbn.aussiebb.net (167-179-156-38.a7b39c.syd.nbn.aussiebb.net [167.179.156.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD81191; Tue, 29 Aug 2023 03:18:29 -0700 (PDT) Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1qavnj-008qMP-7B; Tue, 29 Aug 2023 18:18:24 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Tue, 29 Aug 2023 18:18:24 +0800 Date: Tue, 29 Aug 2023 18:18:24 +0800 From: Herbert Xu To: Andy Shevchenko Cc: Lucas Segarra Fernandez , linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, qat-linux@intel.com, alx@kernel.org, Giovanni Cabiddu Subject: Re: [PATCH v2 1/2] crypto: qat - refactor included headers Message-ID: References: <20230818102322.142582-1-lucas.segarra.fernandez@intel.com> <20230818102322.142582-2-lucas.segarra.fernandez@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Mon, Aug 28, 2023 at 01:46:18PM +0300, Andy Shevchenko wrote: > > kernel.h is misleading here. It includes 98% of something which this file is > not using or going to use. Can you tell _why_ we need that 98% bulk to be > included here? For most drivers in drivers/crypto they will need multiple header files included by kernel.h. I'd hate for people to start posting patches replacing one inclusion of kernel.h with multiple inclusions. They're bound to get it wrong and we'll be forever dealing with random build failures because someone changes a random header elsewhere which then exposes a missed inclusion. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt