From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DB5BC71133 for ; Fri, 25 Aug 2023 11:02:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239790AbjHYLBg (ORCPT ); Fri, 25 Aug 2023 07:01:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54070 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237531AbjHYLBQ (ORCPT ); Fri, 25 Aug 2023 07:01:16 -0400 Received: from 167-179-156-38.a7b39c.syd.nbn.aussiebb.net (167-179-156-38.a7b39c.syd.nbn.aussiebb.net [167.179.156.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A4D21BCC; Fri, 25 Aug 2023 04:01:14 -0700 (PDT) Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1qZUYv-007iVj-7t; Fri, 25 Aug 2023 19:01:10 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Fri, 25 Aug 2023 19:01:10 +0800 Date: Fri, 25 Aug 2023 19:01:10 +0800 From: Herbert Xu To: Lucas Segarra Fernandez Cc: linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, qat-linux@intel.com, andriy.shevchenko@intel.com, alx@kernel.org, Giovanni Cabiddu , Andy Shevchenko Subject: Re: [PATCH v2 2/2] crypto: qat - add pm_status debugfs file Message-ID: References: <20230818102322.142582-1-lucas.segarra.fernandez@intel.com> <20230818102322.142582-3-lucas.segarra.fernandez@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230818102322.142582-3-lucas.segarra.fernandez@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Fri, Aug 18, 2023 at 12:23:09PM +0200, Lucas Segarra Fernandez wrote: > > +#ifdef CONFIG_DEBUG_FS Please avoid such large ifdef blocks. Try to localise it to the lines where it's actually needed. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt