Re: [PATCH v2 1/2] crypto: qat - refactor included headers

Herbert Xu
2023-08-29T10:19:16Z

On Mon, Aug 28, 2023 at 01:46:18PM +0300, Andy Shevchenko wrote:
>
> kernel.h is misleading here. It includes 98% of something which this file is
> not using or going to use. Can you tell _why_ we need that 98% bulk to be
> included here?

For most drivers in drivers/crypto they will need multiple header
files included by kernel.h. I'd hate for people to start posting
patches replacing one inclusion of kernel.h with multiple inclusions.

They're bound to get it wrong and we'll be forever dealing with
random build failures because someone changes a random header
elsewhere which then exposes a missed inclusion.

Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt