From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04396EE6456 for ; Fri, 15 Sep 2023 10:44:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233440AbjIOKoL (ORCPT ); Fri, 15 Sep 2023 06:44:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232796AbjIOKoK (ORCPT ); Fri, 15 Sep 2023 06:44:10 -0400 Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC5F71AB; Fri, 15 Sep 2023 03:43:58 -0700 (PDT) Received: by mail-pf1-x432.google.com with SMTP id d2e1a72fcca58-69002ef0104so1630512b3a.1; Fri, 15 Sep 2023 03:43:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1694774638; x=1695379438; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=UqP1psGcZRdVmUUjw/rzqv6oDKC5zTrt48sqFT23qfI=; b=FKeXWFVLR9byiKTQy/cQ/uT8mca9CeFgwj7tL3pyiRqras7yF5c8oEoobg5GAvIT6E z1JSAGBEi2QSLM1xcoRvZO7tbBaZ/EP2+VT/+yP64mrW+7trOB3axUCLBuM5iboxFCms tv9/LIUYJO3hb+jz6hg6iRKupk2jZg3PySLO8rhqsY/jMCCgtMWW/1//zTc66KPv8ImG ZwFSRZUkvDlQdcIlu2jxW0TRC/sU+9C8nLkrh6Ki9KMGeLSahttdgbGN4W3c6pe/4+Tl ZvYSzQ0+tFcx97mjNaOpbcJPZ/q4+gvp7mT9s9fScmTRekqEBFXyd7KOMwCZkULgb+Pv 5Diw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694774638; x=1695379438; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UqP1psGcZRdVmUUjw/rzqv6oDKC5zTrt48sqFT23qfI=; b=bGFaPbP/y/Sa2GIUSbRtXS7zzB3Jc/1ngo8kbPgBNUJbLMLbZuqDGplDjxbb5h19Z2 2eToYFrPtsguj5ZhWSt6Tlop4qnk7fgHftAlwTQfXsZNkaJGwFDqVmjDMYQckvZkk0FJ aisuV6uCIVkZ0Ix524GmSP4zsRgfghHeCCMn9+MknpZxFETmU/HYw/VsDgy/deswYBzr BaBg7nJ86xhu6gdJixClMqPHvwDZGTSnF9P9pVhgREBXywnYXfY2y0uOtmqgEiFa5kWD fvp7Qp+WJ94TRpFVs3UlP8mOip4N0MkXi0psAhkGiNgRflDD12qkmoqwgou1EzJapL0O RYgA== X-Gm-Message-State: AOJu0Yz0nK+mDrp893g0aJ4PaeZI0C+z0ancuFD4yKjIcoEJAzANxqGa z4fMNSXfm4yYx1EifE7KsFw= X-Google-Smtp-Source: AGHT+IHOCHNovDJgIlga+tOpezqhjzKI6jH+k8BgVMhIvCp0Q/15ToEK4jPuxCUH0jpQL3zgGu2BNw== X-Received: by 2002:a05:6a21:66c6:b0:14c:4deb:7120 with SMTP id ze6-20020a056a2166c600b0014c4deb7120mr1169542pzb.62.1694774638216; Fri, 15 Sep 2023 03:43:58 -0700 (PDT) Received: from gondor.apana.org.au ([2404:c804:1b2a:5507:c00a:8aff:fe00:b003]) by smtp.gmail.com with ESMTPSA id go20-20020a17090b03d400b002612150d958sm4604923pjb.16.2023.09.15.03.43.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Sep 2023 03:43:57 -0700 (PDT) Sender: Herbert Xu Date: Fri, 15 Sep 2023 18:43:57 +0800 From: Herbert Xu To: Christophe JAILLET Cc: Longfang Liu , "David S. Miller" , Zaibo Xu , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-crypto@vger.kernel.org Subject: Re: [PATCH] crypto: hisilicon/hpre - Fix a erroneous check after snprintf() Message-ID: References: <73534cb1713f58228d54ea53a8a137f4ef939bad.1693858632.git.christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <73534cb1713f58228d54ea53a8a137f4ef939bad.1693858632.git.christophe.jaillet@wanadoo.fr> Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Mon, Sep 04, 2023 at 10:17:29PM +0200, Christophe JAILLET wrote: > This error handling looks really strange. > Check if the string has been truncated instead. > > Fixes: 02ab994635eb ("crypto: hisilicon - Fixed some tiny bugs of HPRE") > Signed-off-by: Christophe JAILLET > --- > drivers/crypto/hisilicon/hpre/hpre_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt